Skip to content

WIP Cincinnati: mount credentials secret in e2e test container #7370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrutkovs wants to merge 1 commit into from
Closed

WIP Cincinnati: mount credentials secret in e2e test container #7370

vrutkovs wants to merge 1 commit into from

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Feb 28, 2020

Required to use github token in e2e runs, see openshift/cincinnati#233

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Feb 28, 2020

/hold

to check that rehearsal passes

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2020
steveej
steveej approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@vrutkovs vrutkovs mentioned this pull request Feb 28, 2020
Merged
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Feb 28, 2020

time="2020-02-28T12:13:38Z" level=error msg="Failed to rehearse jobs" error="failed to create watch for ProwJobs: Get https://172.30.0.1:443/apis/prow.k8s.io/v1/namespaces/ci/prowjobs?labelSelector=ci.openshift.org%2Frehearse%3D7370&watch=true: dial tcp 172.30.0.1:443: connect: connection refused" pr=7370

/retest

@vrutkovs vrutkovs mentioned this pull request Feb 28, 2020
Merged
@vrutkovs vrutkovs force-pushed the cincy-mount-creds-in-e2e branch from 0af5a4b to 52d81e2 Compare February 28, 2020 14:39
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
steveej
steveej approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveeJ, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the cincy-mount-creds-in-e2e branch from 52d81e2 to d7f8d0b Compare February 28, 2020 15:30
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2020

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 28, 2020

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2020

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Feb 28, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 28, 2020

/test all

The requirements for Bugzilla bugs have changed, recalculating validity.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Mar 2, 2020

/retest

@vrutkovs vrutkovs force-pushed the cincy-mount-creds-in-e2e branch 3 times, most recently from 6a15e6e to 93ad4fb Compare March 2, 2020 11:05
@vrutkovs vrutkovs force-pushed the cincy-mount-creds-in-e2e branch from 93ad4fb to b733b31 Compare March 2, 2020 11:45
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 2, 2020

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse b733b31 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs changed the title Cincinnati: mount credentials secret in e2e test container WIP Cincinnati: mount credentials secret in e2e test container Mar 2, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Mar 4, 2020

Superseded by #7449

@vrutkovs vrutkovs closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfchevrette jfchevrette Awaiting requested review from jfchevrette

@pbergene pbergene Awaiting requested review from pbergene

1 more reviewer

@steveej steveej steveej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@steveej steveej

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vrutkovs @openshift-ci-robot @openshift-bot @steveej