Skip to content

hypershift: reorder kubevirt presub flow to fix break #69606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Sep 23, 2025
+2 −5
Merged

hypershift: reorder kubevirt presub flow to fix break #69606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...step-registry/hypershift/kubevirt/e2e-nested/hypershift-kubevirt-e2e-nested-workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ workflow:
post:
- chain: hypershift-dump
- chain: gather-core-dump
- chain: hypershift-destroy-nested-management-cluster
- chain: hypershift-kubevirt-destroy
- chain: hypershift-destroy-nested-management-cluster
4 changes: 0 additions & 4 deletions ...stry/hypershift/kubevirt/run-e2e-external/hypershift-kubevirt-run-e2e-external-chain.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,3 @@ chain:
cpu: 100m
memory: 100Mi
timeout: 1h0m0s
- chain: hypershift-kubevirt-destroy
env:
- default: "/tmp/secret/kubeconfig"

@devguyio devguyio Sep 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this env var not needed anymore?

@sjenning sjenning Sep 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what the rehearsal is for 😅. Other chains like hypershift-dump do not specify a KUBECONFIG so I think it is already set.

@devguyio devguyio Sep 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 😁 tagged and 🤞🏽 for the rehearsal

name: KUBECONFIG