Skip to content

Conversation

@everettraven
Copy link
Contributor

We have been running into some issues with the metal jobs in #68209

To help us better test different solutions to hostname resolution, this PR adds one of the metal jobs from #68209 as a presubmit job.

@openshift-ci openshift-ci bot requested review from ibihim and liouk August 21, 2025 13:26
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@everettraven: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-authentication-operator-master-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview openshift/cluster-authentication-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@liouk
Copy link
Member

liouk commented Aug 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@everettraven
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 21, 2025
@everettraven everettraven changed the title cao: add a metal presubmit for testing OIDC functionality CNTRLPLANE-945: cao: add a metal presubmit for testing OIDC functionality Aug 21, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 21, 2025

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

We have been running into some issues with the metal jobs in #68209

To help us better test different solutions to hostname resolution, this PR adds one of the metal jobs from #68209 as a presubmit job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2025
@everettraven
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@everettraven
Copy link
Contributor Author

Rehearsal should fail fairly quickly, but I want to make sure it fails for the expected reason before merging

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@everettraven: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-authentication-operator/master/e2e-metal-ovn-ipv4-external-oidc-configure-techpreview 59ab3e1 link unknown /pj-rehearse pull-ci-openshift-cluster-authentication-operator-master-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven
Copy link
Contributor Author

Rehearsal failed with expected failures. Removing hold so that this can merge and we can begin testing the fix in openshift/origin#30148

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6e320dd into openshift:master Aug 21, 2025
15 of 16 checks passed
JslYoon pushed a commit to JslYoon/openshift-release that referenced this pull request Aug 25, 2025
tbuskey pushed a commit to tbuskey/release that referenced this pull request Aug 26, 2025
etmurasaki pushed a commit to etmurasaki/release that referenced this pull request Sep 3, 2025
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants