-
Notifications
You must be signed in to change notification settings - Fork 2k
CNTRLPLANE-945: cao: add a metal presubmit for testing OIDC functionality #68358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-945: cao: add a metal presubmit for testing OIDC functionality #68358
Conversation
Signed-off-by: Bryce Palmer <[email protected]>
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, liouk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
/pj-rehearse |
|
@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Rehearsal should fail fairly quickly, but I want to make sure it fails for the expected reason before merging |
|
@everettraven: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Rehearsal failed with expected failures. Removing hold so that this can merge and we can begin testing the fix in openshift/origin#30148 /hold cancel |
6e320dd
into
openshift:master
…68358) Signed-off-by: Bryce Palmer <[email protected]>
…68358) Signed-off-by: Bryce Palmer <[email protected]>
…68358) Signed-off-by: Bryce Palmer <[email protected]>
…68358) Signed-off-by: Bryce Palmer <[email protected]>
We have been running into some issues with the metal jobs in #68209
To help us better test different solutions to hostname resolution, this PR adds one of the metal jobs from #68209 as a presubmit job.