CNTRLPLANE-945: oidc/keycloak: make keycloak client use environment proxy for HTTP requests

[everettraven]

We encountered an issue in openshift/release#68209 where requests to configure the Keycloak instance deployed for the OIDC tests failed to resolve the hostname of route for the Keycloak instance.

This appeared to be because all requests to routes on a baremetal cluster must go through a proxy. This PR updates the HTTP client we use for interacting with Keycloak instances to respect any proxies configured from the typical HTTP_PROXY HTTPS_PROXY and NO_PROXY environment variables.

[openshift-ci-robot]

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

Tested this locally on a metal cluster and we were able to successfully configure keycloak through the keycloak route when the HTTP_PROXY and HTTPS_PROXY environment variables were set.

[liouk]

/lgtm

[everettraven]

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-cluster-authentication-operator-778-openshift-origin-30148-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview/1958596586057502720 is evidence that this change fixes the issue we were encountering in the metal jobs in openshift/release#68209

All the feature-gated tests that use this functionality passed against a baremetal cluster, meaning we were successfully able to hit the Keycloak instances and configure them.

[openshift-ci-robot]

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

We encountered an issue in openshift/release#68209 where requests to configure the Keycloak instance deployed for the OIDC tests failed to resolve the hostname of route for the Keycloak instance.

This appeared to be because all requests to routes on a baremetal cluster must go through a proxy. This PR updates the HTTP client we use for interacting with Keycloak instances to respect any proxies configured from the typical HTTP_PROXY HTTPS_PROXY and NO_PROXY environment variables.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/retest-required

[neisw]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, liouk, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cc8ae10 and 2 for PR HEAD cf1354f in total

[everettraven]

/retest-required

[liouk]

/test e2e-metal-ipi-ovn-ipv6

[openshift-trt]

Job Failure Risk Analysis for sha: cf1354f

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (104) are below the historical average (2387): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

[everettraven]

/retest-required

[everettraven]

/retest-required

[everettraven]

This suite is currently only run in tech preview jobs, and shouldn't negatively impact CI/CR signal or the default product.

/label acknowledge-critical-fixes-only

[openshift-ci]

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.