CORS-4027: Updating feature gate name to GCPClusterHostedDNSInstall #67624

sadasu · 2025-07-29T17:19:40Z

GCP Cluster Hosted DNS feature has renamed its associated feature gate to GCPClusterHostedDNSInstall. Updating existing pre-submit and periodic jobs to use this new feature gate name.

sadasu · 2025-07-29T18:28:56Z

/pj-rehearse

openshift-ci-robot · 2025-07-29T18:28:58Z

@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

patrickdillon · 2025-07-29T19:04:14Z

/approve
/lgtm

but the rehearsals will probably fail as the api has not been bumped in the installer. Perhaps we want to hold for that.

openshift-ci-robot · 2025-07-29T19:10:07Z

@sadasu: This pull request references CORS-4027 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

GCP Cluster Hosted DNS feature has renamed its associated feature gate to GCPClusterHostedDNSInstall. Updating existing pre-submit and periodic jobs to use this new feature gate name.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gpei · 2025-07-30T06:18:14Z

/lgtm

jianlinliu · 2025-07-30T11:25:33Z

ci-operator/config/openshift-priv/installer/openshift-priv-installer-release-4.19.yaml

    cluster_profile: gcp-qe
    env:
-      FEATURE_GATES: '["GCPClusterHostedDNS=true"]'
+      FEATURE_GATES: '["GCPClusterHostedDNSInstall=true"]'


The change is only applied to 4.20+, rather than 4.19, right ?

Thanks for the catch. Yes, you're right. We should only update this for 4.20+

/lgtm cancel

Thanks @jianlinliu. I am still stuck in 4.19! Updated. openshift/installer#9854 have also merged.

patrickdillon · 2025-07-30T16:15:31Z

/lgtm cancel

GCP Cluster Hosted DNS feature has renamed its associated feature gate to GCPClusterHostedDNSInstall. Updating existing pre-submit and periodic jobs to use this new feature gate name.

sadasu · 2025-07-30T19:12:49Z

/pj-rehearse

openshift-ci-robot · 2025-07-30T19:12:52Z

@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci-robot · 2025-07-30T19:13:32Z

[REHEARSALNOTIFIER]
@sadasu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-installer-main-e2e-gcp-custom-dns	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-release-4.20-e2e-gcp-custom-dns	openshift/installer	presubmit	Ci-operator config changed
pull-ci-openshift-installer-release-4.21-e2e-gcp-custom-dns	openshift/installer	presubmit	Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-priv-mini-perm-arm-f14	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-custom-dns	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-mini-perm-amd-f28-destructive	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-mini-perm-arm-f14	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-priv-mini-perm-amd-f28-destructive	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

jianlinliu · 2025-07-31T01:50:49Z

/lgtm

gpei · 2025-07-31T10:49:26Z

/pj-rehearse pull-ci-openshift-installer-release-4.20-e2e-gcp-custom-dns

openshift-ci-robot · 2025-07-31T10:49:28Z

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

gpei · 2025-07-31T12:38:43Z

@sadasu Seen from the failed rehearsal jobs, it seems there is a bug in the latest installer.

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/67624/rehearse-67624-pull-ci-openshift-installer-release-4.20-e2e-gcp-custom-dns/1950872250328551424/artifacts/e2e-gcp-custom-dns/ipi-install-install/build-log.txt

=============== openshift-install version ==============
openshift-install unreleased-master-12097-g72c6cb7cde4aa872790b024d44523559c525c1f3-dirty
built from commit 72c6cb7cde4aa872790b024d44523559c525c1f3
release image registry.ci.openshift.org/origin/release:4.20
level=warning msg=Found override for release image (registry.build02.ci.openshift.org/ci-op-cyqk3pgh/release@sha256:ecd12314dd2a3f00c8c1db05671bd2387ac89729484a6a80f98fbc425618de4c). Release Image Architecture is unknown
release architecture unknown
default architecture amd64
level=warning msg=Found override for release image (registry.build02.ci.openshift.org/ci-op-cyqk3pgh/release@sha256:ecd12314dd2a3f00c8c1db05671bd2387ac89729484a6a80f98fbc425618de4c). Release Image Architecture is unknown
level=info msg=Credentials loaded from environment variable "GOOGLE_CLOUD_KEYFILE_JSON", file "/var/run/secrets/ci.openshift.io/cluster-profile/gce.json"
level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: baseDomain: Not found: "Public DNS Zone (XXXXXXXXXXXX/qe1.devcluster.openshift.com)"

The domain qe1.devcluster.openshift.com specified in the install-config is not a valid one on GCP, but in userProvisionedDNS mode, installer shouldn't check whether the domain exists.

jianlinliu · 2025-07-31T14:14:39Z

it seems there is a bug in the latest installer.

I guess this is a regression issue introduced by openshift/installer#9840, ValidatePreExistingPublicDNS is move ahead, before the PR, ValidatePreExistingPublicDNS
will be called only in not Platform.GCP.UserProvisionedDNS case.

patrickdillon · 2025-07-31T18:13:34Z

it seems there is a bug in the latest installer.

I guess this is a regression issue introduced by openshift/installer#9840, ValidatePreExistingPublicDNS is move ahead, before the PR, ValidatePreExistingPublicDNS will be called only in not Platform.GCP.UserProvisionedDNS case.

openshift/installer#9859 should fix it, so that the check is skipped for custom dns

jianlinliu · 2025-08-01T02:47:52Z

/pj-rehearse pull-ci-openshift-installer-release-4.20-e2e-gcp-custom-dns

openshift-ci-robot · 2025-08-01T02:47:54Z

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

gpei · 2025-08-01T06:26:43Z

/lgtm

gpei · 2025-08-01T06:27:43Z

@liangxia @vrutkovs for the approval, thanks

vrutkovs · 2025-08-01T07:23:01Z

/approve

openshift-ci · 2025-08-01T07:23:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei, jianlinliu, liangxia, sadasu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/installer/OWNERS~~ [liangxia,sadasu]
~~ci-operator/config/openshift/openshift-tests-private/OWNERS~~ [liangxia]
~~ci-operator/config/openshift/release/OWNERS~~ [liangxia,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianlinliu · 2025-08-01T07:37:00Z

/pj-rehearse ack

openshift-ci-robot · 2025-08-01T07:37:03Z

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2025-08-01T08:48:29Z

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-mini-perm-amd-f28-destructive	`0105965`	link	unknown	`/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-mini-perm-amd-f28-destructive`
ci/rehearse/openshift/installer/release-4.19/e2e-gcp-custom-dns	`0105965`	link	unknown	`/pj-rehearse pull-ci-openshift-installer-release-4.19-e2e-gcp-custom-dns`
ci/rehearse/openshift/installer/main/e2e-gcp-custom-dns	`017e544`	link	unknown	`/pj-rehearse pull-ci-openshift-installer-main-e2e-gcp-custom-dns`
ci/rehearse/openshift/installer/release-4.21/e2e-gcp-custom-dns	`017e544`	link	unknown	`/pj-rehearse pull-ci-openshift-installer-release-4.21-e2e-gcp-custom-dns`
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-priv-mini-perm-amd-f28-destructive	`017e544`	link	unknown	`/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-priv-mini-perm-amd-f28-destructive`
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-priv-mini-perm-arm-f14	`017e544`	link	unknown	`/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-gcp-ipi-custom-dns-priv-mini-perm-arm-f14`
ci/rehearse/openshift/installer/release-4.20/e2e-gcp-custom-dns	`017e544`	link	unknown	`/pj-rehearse pull-ci-openshift-installer-release-4.20-e2e-gcp-custom-dns`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

…7624) GCP Cluster Hosted DNS feature has renamed its associated feature gate to GCPClusterHostedDNSInstall. Updating existing pre-submit and periodic jobs to use this new feature gate name.

openshift-ci bot requested review from hector-vido and pawanpinjarkar July 29, 2025 17:21

openshift-ci bot assigned patrickdillon Jul 29, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2025

sadasu changed the title ~~Updating feature gate name to GCPClusterHostedDNSInstall~~ CORS-4027: Updating feature gate name to GCPClusterHostedDNSInstall Jul 29, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2025

openshift-ci bot assigned gpei Jul 30, 2025

jianlinliu reviewed Jul 30, 2025

View reviewed changes

jianlinliu mentioned this pull request Jul 30, 2025

refine gcp private and custom-dns presubmit jobs #67649

Merged

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2025

Updating feature gate name to GCPClusterHostedDNSInstall

017e544

GCP Cluster Hosted DNS feature has renamed its associated feature gate to GCPClusterHostedDNSInstall. Updating existing pre-submit and periodic jobs to use this new feature gate name.

sadasu force-pushed the update-gcp-featuregate-name branch from 0105965 to 017e544 Compare July 30, 2025 19:10

openshift-ci bot assigned jianlinliu Jul 31, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025

liangxia approved these changes Aug 1, 2025

View reviewed changes

openshift-ci bot assigned liangxia Aug 1, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 1, 2025

openshift-merge-bot bot merged commit ce37a83 into openshift:master Aug 1, 2025
12 of 19 checks passed

CORS-4027: Updating feature gate name to GCPClusterHostedDNSInstall #67624

CORS-4027: Updating feature gate name to GCPClusterHostedDNSInstall #67624

Uh oh!

Conversation

sadasu commented Jul 29, 2025

Uh oh!

sadasu commented Jul 29, 2025

Uh oh!

openshift-ci-robot commented Jul 29, 2025

Uh oh!

patrickdillon commented Jul 29, 2025

Uh oh!

openshift-ci-robot commented Jul 29, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpei commented Jul 30, 2025

Uh oh!

jianlinliu Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patrickdillon Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

sadasu Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Jul 30, 2025

Uh oh!

sadasu commented Jul 30, 2025

Uh oh!

openshift-ci-robot commented Jul 30, 2025

Uh oh!

openshift-ci-robot commented Jul 30, 2025

Uh oh!

jianlinliu commented Jul 31, 2025

Uh oh!

gpei commented Jul 31, 2025

Uh oh!

openshift-ci-robot commented Jul 31, 2025

Uh oh!

gpei commented Jul 31, 2025

Uh oh!

jianlinliu commented Jul 31, 2025

Uh oh!

patrickdillon commented Jul 31, 2025

Uh oh!

jianlinliu commented Aug 1, 2025

Uh oh!

openshift-ci-robot commented Aug 1, 2025

Uh oh!

gpei commented Aug 1, 2025

Uh oh!

gpei commented Aug 1, 2025

Uh oh!

vrutkovs commented Aug 1, 2025

Uh oh!

openshift-ci bot commented Aug 1, 2025

Uh oh!

jianlinliu commented Aug 1, 2025

Uh oh!

openshift-ci-robot commented Aug 1, 2025

Uh oh!

Uh oh!

openshift-ci bot commented Aug 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci-robot commented Jul 29, 2025 •

edited by openshift-ci bot

Loading

jianlinliu Jul 30, 2025 •

edited

Loading