Skip to content

Conversation

@patrickdillon
Copy link
Contributor

1c9589a added validation to require an existing DNS zone matching the base domain before installation. In custom DNS scenarios, it is valid to create the zone after install, so we should relax the validation in those cases.

1c9589a added validation to
require an existing DNS zone matching the base domain before
installation. In custom DNS scenarios, it is valid to create the
zone after install, so we should relax the validation in those
cases.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 31, 2025

@patrickdillon: This pull request references CORS-3992 which is a valid jira issue.

Details

In response to this:

1c9589a added validation to require an existing DNS zone matching the base domain before installation. In custom DNS scenarios, it is valid to create the zone after install, so we should relax the validation in those cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2025
@openshift-ci openshift-ci bot requested review from jhixson74 and rwsu July 31, 2025 18:10
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025
@sadasu
Copy link
Contributor

sadasu commented Jul 31, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f56b2da into openshift:main Jul 31, 2025
16 of 26 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2025

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-byo-vpc 9a9530e link false /test e2e-gcp-ovn-byo-vpc
ci/prow/e2e-azure-ovn-resourcegroup 9a9530e link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-vsphere-static-ovn 9a9530e link false /test e2e-vsphere-static-ovn
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade 9a9530e link false /test e2e-vsphere-host-groups-ovn-custom-no-upgrade
ci/prow/e2e-vsphere-ovn-multi-network 9a9530e link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-vsphere-ovn-multi-network-techpreview 9a9530e link false /test e2e-vsphere-ovn-multi-network-techpreview
ci/prow/e2e-gcp-custom-endpoints 9a9530e link false /test e2e-gcp-custom-endpoints
ci/prow/e2e-gcp-secureboot 9a9530e link false /test e2e-gcp-secureboot
ci/prow/e2e-vsphere-externallb-ovn 9a9530e link false /test e2e-vsphere-externallb-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.20.0-202507312247.p0.gf56b2da.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer
This PR has been included in build ose-installer-container-v4.20.0-202507312247.p0.gf56b2da.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.20.0-202507312247.p0.gf56b2da.assembly.stream.el9.
All builds following this will include this PR.

@patrickdillon patrickdillon changed the title CORS-3992: skip dns zone validation with custom DNS OCPBUGS-60061: skip dns zone validation with custom DNS Aug 1, 2025
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: Jira Issue OCPBUGS-60061: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60061 has been moved to the MODIFIED state.

Details

In response to this:

1c9589a added validation to require an existing DNS zone matching the base domain before installation. In custom DNS scenarios, it is valid to create the zone after install, so we should relax the validation in those cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants