-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OCPBUGS-60061: skip dns zone validation with custom DNS #9859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-60061: skip dns zone validation with custom DNS #9859
Conversation
1c9589a added validation to require an existing DNS zone matching the base domain before installation. In custom DNS scenarios, it is valid to create the zone after install, so we should relax the validation in those cases.
|
@patrickdillon: This pull request references CORS-3992 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tthvo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f56b2da
into
openshift:main
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
@patrickdillon: Jira Issue OCPBUGS-60061: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-60061 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1c9589a added validation to require an existing DNS zone matching the base domain before installation. In custom DNS scenarios, it is valid to create the zone after install, so we should relax the validation in those cases.