-
Notifications
You must be signed in to change notification settings - Fork 2k
WIP Set '--id CI' in our bootstrap gather hacks #6744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure I understand why some jobs seem to have ended up with bootstrap logs but others weren't. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
We use some tolerant SSH options that the installer wouldn't specify if we were to run `openshift-install bootstrap gather` directly, but now that means we're not setting --id as expected after openshift/installer#1836
34de8ef to
4800148
Compare
|
/retest |
|
I would rather use the installer's gather for these (e.g. #6336). I have no opinion on how these |
|
Thanks, will look that over Monday |
|
@sdodson: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@sdodson: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test prow-config-filenames |
|
@sdodson: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@sdodson: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We use some tolerant SSH options that the installer wouldn't specify if
we were to run
openshift-install bootstrap gatherdirectly, but nowthat means we're not setting --id as expected after
openshift/installer#1836
Fixes this in our CI jobs
/cc @wking