Skip to content

Conversation

@sdodson
Copy link
Member

@sdodson sdodson commented Jan 16, 2020

We use some tolerant SSH options that the installer wouldn't specify if
we were to run openshift-install bootstrap gather directly, but now
that means we're not setting --id as expected after
openshift/installer#1836

Fixes this in our CI jobs

+ echo 'Log bundle written to /var/home/core/log-bundle-.tar.gz'
Log bundle written to /var/home/core/log-bundle-.tar.gz
Could not create directory '/output/.ssh'.
Warning: Permanently added '147.75.73.77' (ECDSA) to the list of known hosts.
scp: log-bundle.tar.gz: No such file or directory

/cc @wking

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2020
@sdodson
Copy link
Member Author

sdodson commented Jan 16, 2020

Not sure I understand why some jobs seem to have ended up with bootstrap logs but others weren't.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdodson
To complete the pull request process, please assign stevekuznetsov
You can assign the PR to them by writing /assign @stevekuznetsov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

We use some tolerant SSH options that the installer wouldn't specify if
we were to run `openshift-install bootstrap gather` directly, but now
that means we're not setting --id as expected after
openshift/installer#1836
@sdodson
Copy link
Member Author

sdodson commented Jan 17, 2020

/retest

@wking
Copy link
Member

wking commented Jan 18, 2020

I would rather use the installer's gather for these (e.g. #6336). I have no opinion on how these ssh are maintained in the interim, but am happy to blindly LGTM anything in the absence of opinionated maintainers.

@sdodson sdodson changed the title Set '--id CI' in our bootstrap gather hacks WIP Set '--id CI' in our bootstrap gather hacks Jan 18, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2020
@sdodson
Copy link
Member Author

sdodson commented Jan 18, 2020

Thanks, will look that over Monday

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2020
@openshift-ci-robot
Copy link
Contributor

@sdodson: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@sdodson: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/test prow-config-filenames

@openshift-ci-robot
Copy link
Contributor

@sdodson: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-api-provider-gcp/master/e2e-gcp-operator 4800148 link /test pj-rehearse
ci/rehearse/openshift-cnv/cnv-ci/master/e2e-test 4800148 link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp 4800148 link /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-azure/master/e2e-azure-operator 4800148 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-metal 4800148 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-scaleup-rhel7 4800148 link /test pj-rehearse
ci/rehearse/openshift/cluster-api-actuator-pkg/master/e2e-azure-operator 4800148 link /test pj-rehearse
ci/prow/pj-rehearse 4800148 link /test pj-rehearse
ci/build-farm/build01-dry 4800148 link /test build01-dry
ci/prow/prow-config-filenames 4800148 link /test prow-config-filenames

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member Author

sdodson commented Feb 13, 2020

/close

@openshift-ci-robot
Copy link
Contributor

@sdodson: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants