cmd/openshift-install/gather: Guard against cluster-side artifact collisions #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XXL
…lisions Support running multiple gather commands without cluster-side collisions. For example: 1. Alice runs gather bootstrap, her command writes a tarball on the bootstrap machine and starts downloading it. 2. Bob runs gather bootstrap, his command starts writing to the same tarball on the bootstrap machine. 3. Alice's download croaks on the truncated file. But maybe Alice's download already has an open file descriptor, so Bob's clobber doesn't break the download? I guess it depends on the specifics of how installer-gather.sh's > ~/log-bundle.tar.gz worked. With this commit, we avoid potential issues by passing in an optional gather ID which the cluster-side scripts use to uniquify their collection directories. We still race if multiple gathers are launched in the same second, but that's at least a narrower window, and we can close it later by using a better source of random characters.
wking
force-pushed
the
bootstrap-side-gather-collisions
branch
from
3d84d15 to
2f5a74e
Compare
openshift-ci-robot
added
size/M
Contributor
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sdodson
added a commit
to sdodson/release
that referenced
this pull request
Jan 16, 2020
We use some tolerant SSH options that the installer wouldn't specify if we were to run `openshift-install bootstrap gather` directly, but now that means we're not setting --id as expected after openshift/installer#1836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support running multiple gather commands without cluster-side collisions. For example:
gather bootstrap, her command writes a tarball on the bootstrap machine and starts downloading it.gather bootstrap, his command starts writing to the same tarball on the bootstrap machine.But maybe Alice's download already has an open file descriptor, so Bob's clobber doesn't break the download? I guess it depends on the specifics of how
installer-gather.sh's> ~/log-bundle.tar.gzworked. With this pull request, we avoid potential issues by passing in an optional gather ID which the cluster-side scripts use to uniquify their collection directories. We still race if multiple gathers are launched in the same second, but that's at least a narrower window, and we can close it later by using a better source of random characters.