Installer aws-upi template to set mastersScheduable false

[jstuever]

Prior to this change, the aws upi template set the compute replicas to
zero but did not set masterScheduable to false. This caused the master
nodes to be schedulable.

This change sets masterScheduable to false to maintain the same
configuration we are asking of our customers in our documentation.

[jstuever]

/cc @wking

[jstuever]

/test pj-rehearse

[patrickdillon]

/lgtm

[patrickdillon]

/lgtm cancel
isn't masterScheduleable already false? https://github.com/openshift/installer/blob/master/pkg/asset/manifests/scheduler.go#L52

[jstuever]

/lgtm cancel
isn't masterScheduleable already false? https://github.com/openshift/installer/blob/master/pkg/asset/manifests/scheduler.go#L52

No... because https://github.com/openshift/installer/blob/master/pkg/asset/manifests/scheduler.go#L73

[patrickdillon]

/lgtm

[wking]

Not loading from disk is a bug. Can we fix this, e.g. like openshift/installer#1211? I'm fine landing this as a temporary hack if folks want.

[jstuever]

Not loading from disk is a bug. Can we fix this, e.g. like openshift/installer#1211? I'm fine landing this as a temporary hack if folks want.

I see how that bug is related. However, here we are fixing the discrepancy between CI and the customer facing docs. Step 4 is not listed as optional:

https://docs.openshift.com/container-platform/4.2/installing/installing_aws/installing-aws-user-infra.html#installation-user-infra-generate-k8s-manifest-ignition_installing-aws-user-infra

[wking]

However, here we are fixing the discrepancy between CI and the customer facing docs.

Fair. And again, I'm fine with this PR as a short-term hack. But I think "haha, we just clobbered the manifest you supplied before calling the installer" is a gotcha that I'd rather avoid. Can we at least get a ticket for accepting those early manifests instead of requreing folks to supply it at just the right time to get slurped in?

[sdodson]

/test pj-rehearse

[sdodson]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, patrickdillon, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/templates/openshift/installer/OWNERS [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jstuever: Updated the following 3 configmaps:

• prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
  • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
• prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster default using the following files:
  • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
• prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci-stg at cluster default using the following files:
  • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml

Details

In response to this:

Prior to this change, the aws upi template set the compute replicas to
zero but did not set masterScheduable to false. This caused the master
nodes to be schedulable.

This change sets masterScheduable to false to maintain the same
configuration we are asking of our customers in our documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

https://bugzilla.redhat.com/show_bug.cgi?id=1794154 for followup on #6741 (comment)

[openshift-ci-robot]

@jstuever: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/fcos/e2e-vsphere	a390790	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi	a390790	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-proxy	a390790	link	/test pj-rehearse
ci/prow/pj-rehearse	a390790	link	/test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.