-
Notifications
You must be signed in to change notification settings - Fork 2.1k
UPI e2e: remove compute section in generated install-config #6713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This ensures masters are not labelled as workers on UPI AWS runs
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
An alternative to this would be setting |
|
/retest |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Okay, that worked - masters are no longer labelled as workers. However invoker test still fails (not sure if its related).
I think that would be a bit more confusing - masters would still be labelled as workers with this, but won't be schedulable? |
|
#6741 talks about |
|
Doesn't removing this from install-config.yaml cause it to just revert to default (with replicas: 3)? |
This ensures masters are not labelled as workers on UPI AWS runs