openstack: Fix unbound variables

[pierreprinetti]

• Fix unbound variables
• [[ is undefined in POSIX sh

[pierreprinetti]

/uncc jcpowermac mtnbikenc
/cc mandre tomassedovic

This might supersede #6727 , if it passes rehearse.

[tomassedovic]

/lgtm
/hold

Holding to make sure it's not merged before demonstrating the OpenStack job is fixed. I like it, thanks!

Hope this works :-)

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/templates/openshift/installer/OWNERS [pierreprinetti,tomassedovic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierreprinetti]

/retest

[tomassedovic]

Okay, the OpenStack job has failed, but it got past the unbound variables issues. And the bootstrapping failure is something we still need to resolve (unrelated to this).

I'm in favour of merging this now, but I'd like to hear @mandre's opinion as well.

[pierreprinetti]

@mandre @tomassedovic

We have a chicken-and-egg problem here with openshift/cluster-image-registry-operator#438 ; however, the startup scripts seems to succeed. I suggest to merge this patch so that we can start fixing the next bug in the stack

[tomassedovic]

@pierreprinetti I thought the CIRO issue (openshift/cluster-image-registry-operator#438) happened much later -- after bootstrapping had completed.

So I think the bootstrap issue we're seeing in the job here is not going to be fixed by that PR. But it isn't related to this change either. I.e. I'm in favour of merging this too.

[pierreprinetti]

👍
/hold cancel

[openshift-ci-robot]

@pierreprinetti: Updated the following 2 configmaps:

• prow-job-cluster-launch-installer-openstack-e2e configmap in namespace ci at cluster default using the following files:
  • key cluster-launch-installer-openstack-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml
• prow-job-cluster-launch-installer-openstack-e2e configmap in namespace ci-stg at cluster default using the following files:
  • key cluster-launch-installer-openstack-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml

Details

In response to this:

• Fix unbound variables
• [[ is undefined in POSIX sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mandre]

A little late to the party 👍

[openshift-ci-robot]

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/cloud-credential-operator/master/e2e-openstack	8b6c24e	link	/test pj-rehearse
ci/prow/pj-rehearse	8b6c24e	link	/test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.