openstack: Relax script checks

[pierreprinetti]

There are unbound variables in the script; they have to be fixed before
we set the unbound variable check.

Additionally, use bash in the setup script, as bash syntax is used.

ref.: #6725

[pierreprinetti]

/uncc jcpowermac mtnbikenc

/cc mandre tomassedovic Fedosin

[tomassedovic]

/lgtm
/hold

I'm putting this on hold to make sure we verify it fixes the OpenStack job. This change (seemingly) introduced the issue and it showed up in the job, but it got merged anyway:

#6725

Anyone feel free to remove the hold once we've verified this fix works.

[mandre]

/lgtm

Hmm, there's something that escape me. The KURYR_ENABLED should be defined in:

release/ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml

Line 24 in 3a4904f

- name: KURYR_ENABLED

However, without this patch, it was complaining that the variable was unbound:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-image-registry-operator/438/pull-ci-openshift-cluster-image-registry-operator-master-e2e-openstack/13/build-log.txt

I agree with the proposed fix: rather than chasing all unbound variables, let's drop the -u flag.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/templates/openshift/installer/OWNERS [mandre,pierreprinetti,tomassedovic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tomassedovic]

I agree with @mandre though I would like us to forbid unbound variables eventually. Let's merge this since it's breaking the OpenStack CI and then investigate this properly.

[mandre]

/test pj-rehearse
/cc bbguimaraes
There were unbound variables after all 🤷‍♂️

[mandre]

I agree with @mandre though I would like us to forbid unbound variables eventually. Let's merge this since it's breaking the OpenStack CI and then investigate this properly.

Of course, I should have said "chasing all unbound variables now" - removing the -u option lets us fix the CI more quickly.

[pierreprinetti]

/close

in favour of #6728

[openshift-ci-robot]

@pierreprinetti: Closed this PR.

Details

In response to this:

/close

in favour of #6728

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/cloud-credential-operator/master/e2e-openstack	3a4904f	link	/test pj-rehearse
ci/prow/pj-rehearse	3a4904f	link	/test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.