Skip to content

RFE-6242: add an optional OpenStack job to cluster-ingress-operator#57477

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shiftstack:cio_osp
Oct 10, 2024
Merged

RFE-6242: add an optional OpenStack job to cluster-ingress-operator#57477
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shiftstack:cio_osp

Conversation

@EmilienM
Copy link
Member

@EmilienM EmilienM commented Oct 4, 2024

We didn't have a job and we want to be able to run one to test our PRs.

@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2024

/assign Miciah

@openshift-ci openshift-ci bot requested review from gcs278 and knobunc October 4, 2024 14:33
@EmilienM
Copy link
Member Author

EmilienM commented Oct 4, 2024

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-openstack-ovn

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@MaysaMacedo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
@EmilienM
Copy link
Member Author

EmilienM commented Oct 8, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 8, 2024
@candita
Copy link
Contributor

candita commented Oct 9, 2024

/assign @gcs278

@Miciah
Copy link
Contributor

Miciah commented Oct 9, 2024

@EmilienM, could you also add an e2e-openstack-operator test to run the openshift/cluster-ingress-operator repository's E2E suite?

@Miciah
Copy link
Contributor

Miciah commented Oct 9, 2024

@EmilienM, is there a Jira ticket that the PR and commit message should reference?

@EmilienM EmilienM changed the title Add an optional OpenStack job to cluster-ingress-operator RFE-6242: add an optional OpenStack job to cluster-ingress-operator Oct 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 10, 2024

@EmilienM: This pull request references RFE-6242 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

Details

In response to this:

We didn't have a job and we want to be able to run one to test our PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member Author

EmilienM commented Oct 10, 2024

@EmilienM, could you also add an e2e-openstack-operator test to run the openshift/cluster-ingress-operator repository's E2E suite?

I don't think we need two OpenStack jobs for presubmit. So if you prefer we could run e2e-openstack-operator instead of the proposed one?
I'll try it and see how it works.

We didn't have a job and we want to be able to run one to test our PRs.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@EmilienM
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-openstack-operator

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-openstack-operator openshift/cluster-ingress-operator presubmit Presubmit changed
pull-ci-openshift-cluster-ingress-operator-release-4.18-e2e-openstack-operator openshift/cluster-ingress-operator presubmit Presubmit changed
pull-ci-openshift-cluster-ingress-operator-release-4.19-e2e-openstack-operator openshift/cluster-ingress-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 10, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

@EmilienM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-ingress-operator/master/e2e-openstack-operator a65d5a9 link unknown /pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-openstack-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member Author

EmilienM commented Oct 10, 2024

@Miciah running CIO e2e failed on OpenStack:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1a774eb]

goroutine 11358 [running]:
testing.tRunner.func1.2({0x1d3d600, 0x3428a50})
	/usr/lib/golang/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/usr/lib/golang/src/testing/testing.go:1634 +0x377
panic({0x1d3d600?, 0x3428a50?})
	/usr/lib/golang/src/runtime/panic.go:770 +0x132
github.com/openshift/cluster-ingress-operator/test/e2e.updateDNSConfig(...)
	/go/src/github.com/openshift/cluster-ingress-operator/test/e2e/dns_ingressdegrade_test.go:89
github.com/openshift/cluster-ingress-operator/test/e2e.TestIngressStatus(0xc000511380)
	/go/src/github.com/openshift/cluster-ingress-operator/test/e2e/dns_ingressdegrade_test.go:53 +0x34b
testing.tRunner(0xc000511380, 0x218c9f8)
	/usr/lib/golang/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 11200
	/usr/lib/golang/src/testing/testing.go:1742 +0x390
FAIL	github.com/openshift/cluster-ingress-operator/test/e2e	1612.553s
FAIL
make: *** [Makefile:56: test-e2e] Error 1

@EmilienM
Copy link
Member Author

Fixing it here: openshift/cluster-ingress-operator#1153

@Miciah
Copy link
Contributor

Miciah commented Oct 10, 2024

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, MaysaMacedo, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 10, 2024
@EmilienM
Copy link
Member Author

let's merge it so we can test openshift/cluster-ingress-operator#1153 on OpenStack !

@openshift-merge-bot openshift-merge-bot bot merged commit 74e77b2 into openshift:master Oct 10, 2024
@openshift-merge-bot openshift-merge-bot bot deleted the cio_osp branch October 10, 2024 20:21
josecastillolema pushed a commit to josecastillolema/release that referenced this pull request Oct 15, 2024
…57477)

We didn't have a job and we want to be able to run one to test our PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants