OCPBUGS-43033: e2e/ingress_dns: support both private & public #1153

EmilienM · 2024-10-10T11:25:29Z

Some platforms only have public zones, some others private, some none.
Let's just run zone update tests where applicable so we support
all platforms and also cover more scenarios.

openshift-ci-robot · 2024-10-10T11:25:33Z

@EmilienM: This pull request references Jira Issue OCPBUGS-43033, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fix a nil pointer in the e2e tests for DNS/ingress.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

EmilienM · 2024-10-10T11:26:16Z

/jira refresh

openshift-ci-robot · 2024-10-10T11:26:23Z

@EmilienM: This pull request references Jira Issue OCPBUGS-43033, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

EmilienM · 2024-10-10T11:26:37Z

/assign Miciah

EmilienM · 2024-10-10T13:50:09Z

/test e2e-azure-operator

test/e2e/dns_ingressdegrade_test.go

openshift-ci-robot · 2024-10-10T19:58:57Z

@EmilienM: This pull request references Jira Issue OCPBUGS-43033, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Some platforms only have public zones, some others private, some none.
Let's just run zone update tests where applicable so we support
all platforms and also cover more scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

EmilienM · 2024-10-10T20:22:33Z

/test e2e-openstack-operator

openshift-ci · 2024-10-10T20:22:45Z

@EmilienM: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-azure-operator
/test e2e-gcp-operator
/test e2e-hypershift
/test images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test e2e-aws-gatewayapi
/test e2e-aws-operator-techpreview
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-techpreview
/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-gcp-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator-techpreview
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-serial
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-techpreview
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift
pull-ci-openshift-cluster-ingress-operator-master-images
pull-ci-openshift-cluster-ingress-operator-master-unit
pull-ci-openshift-cluster-ingress-operator-master-verify

Details

In response to this:

/test e2e-openstack-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

EmilienM · 2024-10-10T20:29:03Z

/test e2e-openstack-operator

EmilienM · 2024-10-11T01:26:48Z

/test e2e-openstack-operator

Some platforms only have public zones, some others private, some none. Let's just run zone update tests where applicable so we support all platforms and also cover more scenarios.

EmilienM · 2024-10-11T13:05:08Z

/test e2e-openstack-operator

Miciah

Thanks!

/approve
/lgtm

/hold
since I made some comments, but feel free just to /hold cancel if you want to keep the PR as is.

Miciah · 2024-10-11T14:34:02Z

test/e2e/dns_ingressdegrade_test.go

@@ -39,6 +40,23 @@ func TestIngressStatus(t *testing.T) {
 		t.Fatalf("failed to get DNS config: %v", err)
 	}



You should be able to remove the Get(..., ..., &dnsConfig) above since TestMain initializes dnsConfig, but we can keep it if you prefer to keep the test logic self-contained.

For that matter, we should use kclient that TestMain also initializes, but that can be left as a follow-up clean-up.

I'll try doing it here

I'll follow-up with a PR to address both comments. That'll help me to iterate at the same time on my other PR for LB.
Thanks

Miciah · 2024-10-11T14:37:01Z

test/e2e/dns_ingressdegrade_test.go

+func testUpdateDNSConfig(t *testing.T, kubeClient client.Client) {
+	if err := kubeClient.Get(context.TODO(), types.NamespacedName{Name: "cluster"}, &dnsConfig); err != nil {


I would suggest adding t.Helper(), but maybe that would obfuscate that testUpdateDNSConfig really contains the test. Really, the correct thing might be for TestIngressStatus to use t.Run(..., testUpdateDNSConfig), but I don't think it really matters that much.

I'm in favor of doing it as a follow-up with your help maybe. I've tried myself and I suspect I didn't get it right.

openshift-ci · 2024-10-11T14:38:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

EmilienM · 2024-10-11T14:51:17Z

/test e2e-hypershift

EmilienM · 2024-10-11T16:00:48Z

/hold cancel
The tests on OpenStack fail for another reason. Will fix via another PR

EmilienM · 2024-10-11T16:01:15Z

OpenStack errors: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-ingress-operator/1153/pull-ci-openshift-cluster-ingress-operator-master-e2e-openstack-operator/1844725964710350848/artifacts/e2e-openstack-operator/test/build-log.txt

openshift-ci · 2024-10-11T16:34:38Z

@EmilienM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-operator	`77fb903`	link	false	`/test e2e-openstack-operator`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-10-11T16:38:52Z

@EmilienM: Jira Issue OCPBUGS-43033: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#1153

Jira Issue OCPBUGS-43033 has been moved to the MODIFIED state.

Details

In response to this:

Some platforms only have public zones, some others private, some none.
Let's just run zone update tests where applicable so we support
all platforms and also cover more scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-10-11T22:55:10Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.18.0-202410112106.p0.g8bf1b36.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 10, 2024

EmilienM mentioned this pull request Oct 10, 2024

RFE-6242: add an optional OpenStack job to cluster-ingress-operator openshift/release#57477

Merged

openshift-ci bot requested review from candita and miheer October 10, 2024 11:26

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 10, 2024

openshift-ci bot requested a review from lihongan October 10, 2024 11:26

openshift-ci bot assigned Miciah Oct 10, 2024

Miciah reviewed Oct 10, 2024

View reviewed changes

test/e2e/dns_ingressdegrade_test.go Outdated Show resolved Hide resolved

EmilienM force-pushed the e2e_dns_nil branch from f02ba49 to 8577cb0 Compare October 10, 2024 19:58

EmilienM changed the title ~~OCPBUGS-43033: fix a nil pointer error in e2e/dns_ingress~~ OCPBUGS-43033: e2e/ingress_dns: support both private & public Oct 10, 2024

EmilienM force-pushed the e2e_dns_nil branch from 8577cb0 to dd9cb73 Compare October 11, 2024 01:26

OCPBUGS-43033: e2e/ingress_dns: support both private & public

77fb903

Some platforms only have public zones, some others private, some none. Let's just run zone update tests where applicable so we support all platforms and also cover more scenarios.

EmilienM force-pushed the e2e_dns_nil branch from dd9cb73 to 77fb903 Compare October 11, 2024 13:04

Miciah reviewed Oct 11, 2024

View reviewed changes

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 11, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024

openshift-merge-bot bot merged commit 8bf1b36 into openshift:master Oct 11, 2024

EmilienM deleted the e2e_dns_nil branch October 11, 2024 18:35

		@@ -39,6 +40,23 @@ func TestIngressStatus(t *testing.T) {
		t.Fatalf("failed to get DNS config: %v", err)
		}

		func testUpdateDNSConfig(t *testing.T, kubeClient client.Client) {
		if err := kubeClient.Get(context.TODO(), types.NamespacedName{Name: "cluster"}, &dnsConfig); err != nil {

OCPBUGS-43033: e2e/ingress_dns: support both private & public #1153

OCPBUGS-43033: e2e/ingress_dns: support both private & public #1153

Uh oh!

Conversation

EmilienM commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 10, 2024

Uh oh!

EmilienM commented Oct 10, 2024

Uh oh!

openshift-ci-robot commented Oct 10, 2024

Uh oh!

EmilienM commented Oct 10, 2024

Uh oh!

EmilienM commented Oct 10, 2024

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 10, 2024

Uh oh!

EmilienM commented Oct 10, 2024

Uh oh!

openshift-ci bot commented Oct 10, 2024

Uh oh!

EmilienM commented Oct 10, 2024

Uh oh!

EmilienM commented Oct 11, 2024

Uh oh!

EmilienM commented Oct 11, 2024

Uh oh!

Miciah left a comment

Choose a reason for hiding this comment

Uh oh!

Miciah Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

EmilienM Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

EmilienM Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

Miciah Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

EmilienM Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 11, 2024

Uh oh!

EmilienM commented Oct 11, 2024

Uh oh!

EmilienM commented Oct 11, 2024

Uh oh!

EmilienM commented Oct 11, 2024

Uh oh!

openshift-ci bot commented Oct 11, 2024

Uh oh!

openshift-ci-robot commented Oct 11, 2024

Uh oh!

openshift-bot commented Oct 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

EmilienM commented Oct 10, 2024 •

edited

Loading