Skip to content

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jul 22, 2024

Until work on https://issues.redhat.com/browse/MULTIARCH-4552 is completed, the imagestream tests are expected to fail on multi-arch clusters.

I have created https://issues.redhat.com/browse/MULTIARCH-4821 so we review these tests again and re-enable them in case they are supposed to pass.

r4f4 added 2 commits July 22, 2024 17:35
The `skip_if_only_changed` is a leftover from previous dev iterations of
the test being added.
Until work on https://issues.redhat.com/browse/MULTIARCH-4552 is
completed, the imagestream tests are expected to fail on multi-arch
clusters.
@r4f4
Copy link
Contributor Author

r4f4 commented Jul 22, 2024

/cc @tvardema @jeffdyoung

@openshift-ci openshift-ci bot requested review from jeffdyoung and tvardema July 22, 2024 15:39
@openshift-ci openshift-ci bot requested review from bfournie and rwsu July 22, 2024 15:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@r4f4: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-aws-ovn-heterogeneous openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-ovn-heterogeneous openshift/installer presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 22, 2024

/pj-rehearse pull-ci-openshift-installer-master-e2e-aws-ovn-heterogeneous

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 23, 2024

/pj-rehearse pull-ci-openshift-installer-master-e2e-gcp-ovn-heterogeneous

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 23, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9d35fdc into openshift:master Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants