MULTIARCH-4777: gcp: support multi-arch nodes #8701

r4f4 · 2024-07-03T22:15:43Z

This PR adds support for multi-arch nodes in GCP (amd64 controlPlane and arm64 compute, or vice-versa).

/hold

Depends on:

MULTIARCH-4569: aws: support multi-arch nodes #8698
CI jobs: so we can test the multi-arch part of this change.

openshift-ci-robot · 2024-07-03T22:15:47Z

@r4f4: This pull request references MULTIARCH-4777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

This PR adds support for multi-arch nodes in GCP (amd64 controlPlane and arm64 compute, or vice-versa).

/hold

Depends on:

MULTIARCH-4569: aws: support multi-arch nodes #8698

CI jobs: so we can test the multi-arch part of this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2024-07-03T22:18:41Z

Testing this locally with CAPI/GCP provisioning:

[root@86b7df8f13f1 c]# oc get machines -n openshift-machine-api
NAME                                         PHASE     TYPE             REGION        ZONE            AGE
rdossant-installer-07-vslc9-master-0         Running   n2-standard-4    us-central1   us-central1-a   12m
rdossant-installer-07-vslc9-master-1         Running   n2-standard-4    us-central1   us-central1-b   12m
rdossant-installer-07-vslc9-master-2         Running   n2-standard-4    us-central1   us-central1-c   12m
rdossant-installer-07-vslc9-worker-a-bqtpb   Running   t2a-standard-4   us-central1   us-central1-a   8m10s
rdossant-installer-07-vslc9-worker-b-nvmg4   Running   t2a-standard-4   us-central1   us-central1-b   8m10s
rdossant-installer-07-vslc9-worker-f-pgxlf   Running   t2a-standard-4   us-central1   us-central1-f   8m10s

t2a-standard-* are arm64 instance types.

r4f4 · 2024-07-03T22:18:57Z

/cc @jeffdyoung

r4f4 · 2024-07-04T07:56:08Z

/test altinfra-e2e-gcp-capi-ovn

openshift-ci-robot · 2024-07-16T08:11:34Z

@r4f4: This pull request references MULTIARCH-4777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

This PR adds support for multi-arch nodes in GCP (amd64 controlPlane and arm64 compute, or vice-versa).

/hold

Depends on:

MULTIARCH-4569: aws: support multi-arch nodes #8698

CI jobs: so we can test the multi-arch part of this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2024-07-16T18:03:14Z

/label platform-gcp

openshift-ci · 2024-07-16T18:03:18Z

@r4f4: The label(s) /label platform-gcp cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label platform-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

r4f4 · 2024-07-16T18:03:37Z

/label platform-google

openshift-ci · 2024-07-16T18:03:39Z

@r4f4: The label(s) /label platform-google cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label platform-google

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

r4f4 · 2024-07-16T18:04:05Z

3rd time is the charm
/label platform/google

r4f4 · 2024-07-18T22:12:43Z

/test ?

openshift-ci · 2024-07-18T22:13:23Z

@r4f4: The following commands are available to trigger required jobs:

/test agent-integration-tests
/test altinfra-images
/test aro-unit
/test e2e-agent-compact-ipv4
/test e2e-aws-ovn
/test e2e-aws-ovn-edge-zones-manifest-validation
/test e2e-aws-ovn-upi
/test e2e-azure-ovn
/test e2e-azure-ovn-upi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test gofmt
/test golint
/test govet
/test images
/test okd-images
/test okd-unit
/test okd-verify-codegen
/test openstack-manifests
/test shellcheck
/test terraform-images
/test terraform-verify-vendor
/test tf-lint
/test unit
/test verify-codegen
/test verify-vendor
/test yaml-lint

The following commands are available to trigger optional jobs:

/test altinfra-e2e-aws-custom-security-groups
/test altinfra-e2e-aws-ovn
/test altinfra-e2e-aws-ovn-fips
/test altinfra-e2e-aws-ovn-imdsv2
/test altinfra-e2e-aws-ovn-localzones
/test altinfra-e2e-aws-ovn-proxy
/test altinfra-e2e-aws-ovn-public-ipv4-pool
/test altinfra-e2e-aws-ovn-shared-vpc
/test altinfra-e2e-aws-ovn-shared-vpc-local-zones
/test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones
/test altinfra-e2e-aws-ovn-single-node
/test altinfra-e2e-aws-ovn-wavelengthzones
/test altinfra-e2e-azure-capi-ovn
/test altinfra-e2e-azure-ovn-shared-vpc
/test altinfra-e2e-gcp-capi-ovn
/test altinfra-e2e-gcp-ovn-byo-network-capi
/test altinfra-e2e-gcp-ovn-secureboot-capi
/test altinfra-e2e-gcp-ovn-xpn-capi
/test altinfra-e2e-ibmcloud-capi-ovn
/test altinfra-e2e-nutanix-capi-ovn
/test altinfra-e2e-openstack-capi-ccpmso
/test altinfra-e2e-openstack-capi-ccpmso-zone
/test altinfra-e2e-openstack-capi-dualstack
/test altinfra-e2e-openstack-capi-dualstack-upi
/test altinfra-e2e-openstack-capi-dualstack-v6primary
/test altinfra-e2e-openstack-capi-externallb
/test altinfra-e2e-openstack-capi-nfv-intel
/test altinfra-e2e-openstack-capi-ovn
/test altinfra-e2e-openstack-capi-proxy
/test altinfra-e2e-powervs-capi-ovn
/test altinfra-e2e-vsphere-capi-multi-vcenter-ovn
/test altinfra-e2e-vsphere-capi-ovn
/test altinfra-e2e-vsphere-capi-static-ovn
/test altinfra-e2e-vsphere-capi-zones
/test azure-ovn-marketplace-images
/test e2e-agent-compact-ipv4-appliance-diskimage
/test e2e-agent-compact-ipv4-none-platform
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv4-pxe
/test e2e-agent-sno-ipv6
/test e2e-aws-overlay-mtu-ovn-1200
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-heterogeneous
/test e2e-aws-ovn-imdsv2
/test e2e-aws-ovn-proxy
/test e2e-aws-ovn-public-subnets
/test e2e-aws-ovn-shared-vpc-custom-security-groups
/test e2e-aws-ovn-shared-vpc-edge-zones
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-upi-proxy
/test e2e-azure-ovn-resourcegroup
/test e2e-azure-ovn-shared-vpc
/test e2e-azurestack
/test e2e-azurestack-upi
/test e2e-crc
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-gcp-ovn-byo-vpc
/test e2e-gcp-ovn-heterogeneous
/test e2e-gcp-ovn-xpn
/test e2e-gcp-secureboot
/test e2e-gcp-upgrade
/test e2e-gcp-upi-xpn
/test e2e-ibmcloud-ovn
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-swapped-hosts
/test e2e-metal-ipi-ovn-virtualmedia
/test e2e-metal-single-node-live-iso
/test e2e-nutanix-ovn
/test e2e-openstack-ccpmso
/test e2e-openstack-ccpmso-zone
/test e2e-openstack-dualstack
/test e2e-openstack-dualstack-upi
/test e2e-openstack-externallb
/test e2e-openstack-nfv-intel
/test e2e-openstack-proxy
/test e2e-vsphere-ovn-techpreview
/test e2e-vsphere-ovn-upi-zones
/test e2e-vsphere-ovn-zones
/test e2e-vsphere-ovn-zones-techpreview
/test e2e-vsphere-static-ovn
/test okd-e2e-agent-compact-ipv4
/test okd-e2e-agent-ha-dualstack
/test okd-e2e-agent-sno-ipv6
/test okd-e2e-aws-ovn
/test okd-e2e-aws-ovn-upgrade
/test okd-e2e-gcp
/test okd-e2e-gcp-ovn-upgrade
/test okd-e2e-vsphere
/test okd-scos-e2e-aws-ovn
/test okd-scos-images
/test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn
pull-ci-openshift-installer-master-altinfra-images
pull-ci-openshift-installer-master-aro-unit
pull-ci-openshift-installer-master-e2e-aws-ovn
pull-ci-openshift-installer-master-e2e-aws-ovn-edge-zones
pull-ci-openshift-installer-master-e2e-aws-ovn-edge-zones-manifest-validation
pull-ci-openshift-installer-master-e2e-aws-ovn-fips
pull-ci-openshift-installer-master-e2e-aws-ovn-heterogeneous
pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2
pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-custom-security-groups
pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-edge-zones
pull-ci-openshift-installer-master-e2e-aws-ovn-single-node
pull-ci-openshift-installer-master-e2e-external-aws-ccm
pull-ci-openshift-installer-master-e2e-nutanix-ovn
pull-ci-openshift-installer-master-e2e-openstack-nfv-intel
pull-ci-openshift-installer-master-e2e-openstack-ovn
pull-ci-openshift-installer-master-e2e-openstack-proxy
pull-ci-openshift-installer-master-e2e-vsphere-ovn
pull-ci-openshift-installer-master-e2e-vsphere-ovn-techpreview
pull-ci-openshift-installer-master-e2e-vsphere-ovn-zones
pull-ci-openshift-installer-master-e2e-vsphere-ovn-zones-techpreview
pull-ci-openshift-installer-master-gofmt
pull-ci-openshift-installer-master-golint
pull-ci-openshift-installer-master-govet
pull-ci-openshift-installer-master-images
pull-ci-openshift-installer-master-okd-unit
pull-ci-openshift-installer-master-okd-verify-codegen
pull-ci-openshift-installer-master-openstack-manifests
pull-ci-openshift-installer-master-shellcheck
pull-ci-openshift-installer-master-tf-fmt
pull-ci-openshift-installer-master-tf-lint
pull-ci-openshift-installer-master-unit
pull-ci-openshift-installer-master-verify-codegen
pull-ci-openshift-installer-master-verify-vendor
pull-ci-openshift-installer-master-yaml-lint

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

r4f4 · 2024-07-18T22:13:42Z

/test e2e-gcp-ovn-heterogeneous

This is a fallout of 77234cc when the license field support was removed.

openshift-ci-robot · 2024-07-19T21:19:06Z

@r4f4: This pull request references MULTIARCH-4777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

This PR adds support for multi-arch nodes in GCP (amd64 controlPlane and arm64 compute, or vice-versa).

/hold

Depends on:

MULTIARCH-4569: aws: support multi-arch nodes #8698

CI jobs: so we can test the multi-arch part of this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2024-07-19T21:19:52Z

/hold cancel

The AWS PR this depended on has merged and we have a CI job to test this.

r4f4 · 2024-07-19T22:55:38Z

/test e2e-gcp-ovn-heterogeneous

r4f4 · 2024-07-20T06:59:02Z

/test altinfra-images

openshift-ci · 2024-07-20T07:23:09Z

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-single-node-live-iso	94c7dace52c68f5e08fad51e061896f89cece354	link	false	`/test e2e-metal-single-node-live-iso`
ci/prow/e2e-metal-ipi-ovn-swapped-hosts	94c7dace52c68f5e08fad51e061896f89cece354	link	false	`/test e2e-metal-ipi-ovn-swapped-hosts`
ci/prow/e2e-azurestack	94c7dace52c68f5e08fad51e061896f89cece354	link	false	`/test e2e-azurestack`
ci/prow/e2e-openstack-proxy	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-aws-ovn-edge-zones	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	false	`/test e2e-aws-ovn-edge-zones`
ci/prow/e2e-aws-ovn-single-node	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-vsphere-ovn-techpreview	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	false	`/test e2e-vsphere-ovn-techpreview`
ci/prow/e2e-vsphere-ovn	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	true	`/test e2e-vsphere-ovn`
ci/prow/e2e-openstack-ovn	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	true	`/test e2e-openstack-ovn`
ci/prow/altinfra-e2e-aws-ovn	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	false	`/test altinfra-e2e-aws-ovn`
ci/prow/e2e-vsphere-ovn-zones	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	false	`/test e2e-vsphere-ovn-zones`
ci/prow/e2e-vsphere-ovn-zones-techpreview	d5c87a92bb05721738f8ef9b2166c3874ea5b049	link	false	`/test e2e-vsphere-ovn-zones-techpreview`
ci/prow/e2e-gcp-ovn-heterogeneous	`261ed11`	link	false	`/test e2e-gcp-ovn-heterogeneous`
ci/prow/e2e-aws-ovn-heterogeneous	`261ed11`	link	false	`/test e2e-aws-ovn-heterogeneous`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

patrickdillon · 2024-07-22T15:28:49Z

/approve
/lgtm

openshift-ci · 2024-07-22T15:33:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

r4f4 · 2024-07-22T15:41:52Z

The failing e2e tests are expected to fail and we'll skip them once openshift/release#54643 merges.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024

openshift-ci bot requested review from andfasano and pierreprinetti July 3, 2024 22:17

openshift-ci bot requested a review from jeffdyoung July 3, 2024 22:18

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2024

r4f4 mentioned this pull request Jul 16, 2024

MULTIARCH-4785 Multiarch Compute Day 0 arm x86 GCP openshift/release#54324

Merged

openshift-ci bot added the platform/google label Jul 16, 2024

r4f4 force-pushed the gcp-multi-arch-day-0 branch from 94c7dac to d5c87a9 Compare July 18, 2024 22:12

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024

r4f4 added 2 commits July 19, 2024 23:18

ic: allow multi-arch clusters for GCP when feature gate enabled

b16323c

cluster/tfvars: remove GCP letfover code

261ed11

This is a fallout of 77234cc when the license field support was removed.

r4f4 force-pushed the gcp-multi-arch-day-0 branch from d5c87a9 to 261ed11 Compare July 19, 2024 21:18

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024

openshift-ci bot assigned patrickdillon Jul 22, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024

openshift-merge-bot bot merged commit c45a963 into openshift:master Jul 22, 2024

MULTIARCH-4777: gcp: support multi-arch nodes #8701

MULTIARCH-4777: gcp: support multi-arch nodes #8701

Uh oh!

Conversation

r4f4 commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 3, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r4f4 commented Jul 3, 2024

Uh oh!

r4f4 commented Jul 3, 2024

Uh oh!

r4f4 commented Jul 4, 2024

Uh oh!

openshift-ci-robot commented Jul 16, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

openshift-ci bot commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

openshift-ci bot commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 16, 2024

Uh oh!

r4f4 commented Jul 18, 2024

Uh oh!

openshift-ci bot commented Jul 18, 2024

Uh oh!

r4f4 commented Jul 18, 2024

Uh oh!

openshift-ci-robot commented Jul 19, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r4f4 commented Jul 19, 2024

Uh oh!

r4f4 commented Jul 19, 2024

Uh oh!

r4f4 commented Jul 20, 2024

Uh oh!

openshift-ci bot commented Jul 20, 2024

Uh oh!

patrickdillon commented Jul 22, 2024

Uh oh!

openshift-ci bot commented Jul 22, 2024

Uh oh!

r4f4 commented Jul 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

r4f4 commented Jul 3, 2024 •

edited

Loading

openshift-ci-robot commented Jul 3, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 16, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 19, 2024 •

edited by openshift-ci bot

Loading