Skip to content

[azure-workload-identity] rename Dockerfile#53873

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ashwindasr:rename-azure-workload-identity-dockerfile
Jul 1, 2024
Merged

[azure-workload-identity] rename Dockerfile#53873
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ashwindasr:rename-azure-workload-identity-dockerfile

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr marked this pull request as ready for review July 1, 2024 19:53
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ashwindasr
Copy link
Contributor Author

/hold

Needs to merge with openshift/azure-workload-identity#23

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@ashwindasr ashwindasr changed the title OCPBUGS-36402 [azure-workload-identity] rename Dockerfile [azure-workload-identity] [OCPBUGS-36402] rename Dockerfile Jul 1, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2024
@ashwindasr ashwindasr changed the title [azure-workload-identity] [OCPBUGS-36402] rename Dockerfile [azure-workload-identity] rename Dockerfile Jul 1, 2024
@openshift-ci openshift-ci bot requested review from 2uasimojo and suhanime July 1, 2024 19:55
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ashwindasr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-azure-workload-identity-main-e2e-azure openshift/azure-workload-identity presubmit Ci-operator config changed
pull-ci-openshift-azure-workload-identity-main-images openshift/azure-workload-identity presubmit Ci-operator config changed
pull-ci-openshift-azure-workload-identity-main-okd-scos-images openshift/azure-workload-identity presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dlom
Copy link
Contributor

dlom commented Jul 1, 2024

/lgtm

@dlom
Copy link
Contributor

dlom commented Jul 1, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@dlom
Copy link
Contributor

dlom commented Jul 1, 2024

/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

@dlom: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@ashwindasr
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8027a99 into openshift:master Jul 1, 2024
@ashwindasr ashwindasr deleted the rename-azure-workload-identity-dockerfile branch July 1, 2024 22:20
JianLi-RH pushed a commit to JianLi-RH/release that referenced this pull request Jul 2, 2024
aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 5, 2024
ptalgulk01 pushed a commit to ptalgulk01/release that referenced this pull request Jul 10, 2024
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments