Skip to content

OCPBUGS-36402: Rename Dockerfile.rhel7 to Dockerfile.ocp#23

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ashwindasr:fix-dockerfile-name
Jul 2, 2024
Merged

OCPBUGS-36402: Rename Dockerfile.rhel7 to Dockerfile.ocp#23
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ashwindasr:fix-dockerfile-name

Conversation

@ashwindasr
Copy link

@ashwindasr ashwindasr commented Jul 1, 2024

Refactor name to Dockerfile.ocp as a better, version independent, alternative to Dockerfile.rhel7 since contents are actually rhel9.

CI PR: openshift/release#53873

Please follow up with other changes in this/other repos if necessary. ART has setup a fallback for this repo for 4.17, hence no other configuration is required from ART's side for 4.17.

@openshift-ci openshift-ci bot requested review from 2uasimojo and suhanime July 1, 2024 19:40
@ashwindasr ashwindasr changed the title Rename Dockerfile to Dockerfile.ocp Rename Dockerfile.rhel7 to Dockerfile.ocp Jul 1, 2024
@ashwindasr ashwindasr changed the title Rename Dockerfile.rhel7 to Dockerfile.ocp OCPBUGS-36402: Rename Dockerfile.rhel7 to Dockerfile.ocp Jul 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 1, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36402, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better alternative to Dockerfile.rhel7 since contents are actually rhel9.

Please follow up with other changes in this/other repos if necessary. ART has setup a fallback for this repo, hence this PR can merge whenever ready.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36402, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 1, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36402, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr
Copy link
Author

Raised openshift/release#53873 to update CI.

@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36402, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

Details

In response to this:

Refactor name to Dockerfile.ocp as a better alternative to Dockerfile.rhel7 since contents are actually rhel9.

CI PR: openshift/release#53873

Please follow up with other changes in this/other repos if necessary. ART has setup a fallback for this repo, hence this PR can merge whenever ready.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom
Copy link

dlom commented Jul 1, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@ashwindasr
Copy link
Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 2, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 75b1b4c into openshift:main Jul 2, 2024
@openshift-ci-robot
Copy link

@ashwindasr: Jira Issue OCPBUGS-36402: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36402 has been moved to the MODIFIED state.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative to Dockerfile.rhel7 since contents are actually rhel9.

CI PR: openshift/release#53873

Please follow up with other changes in this/other repos if necessary. ART has setup a fallback for this repo, hence no additional changes are needed from ART's side

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@ashwindasr: Jira Issue OCPBUGS-36402 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative to Dockerfile.rhel7 since contents are actually rhel9.

CI PR: openshift/release#53873

Please follow up with other changes in this/other repos if necessary. ART has setup a fallback for this repo for 4.17, hence no other configuration is required from ART's side for 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr ashwindasr deleted the fix-dockerfile-name branch July 2, 2024 02:39
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-workload-identity-webhook-container-v4.17.0-202407020721.p0.g75b1b4c.assembly.stream.el9 for distgit ose-azure-workload-identity-webhook.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments