Skip to content

Update verify-client-go to work with go 1.22 #52368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 23, 2024
Merged

Update verify-client-go to work with go 1.22 #52368

openshift-merge-bot merged 1 commit into from
May 23, 2024

Conversation

@soltysh
Copy link

@soltysh soltysh commented May 22, 2024

dinhxuanvu
dinhxuanvu reviewed May 22, 2024
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot requested review from deads2k and knobunc May 22, 2024 14:23
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 22, 2024
@dinhxuanvu
Copy link
Member

dinhxuanvu commented May 22, 2024

/pj-rehearse pull-ci-openshift-api-master-verify-client-go

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2024

@dinhxuanvu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dinhxuanvu
Copy link
Member

dinhxuanvu commented May 22, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2024
dinhxuanvu
dinhxuanvu suggested changes May 22, 2024
View reviewed changes
ci-operator/config/openshift/api/openshift-api-master.yaml Outdated
rm -rf $dir/vendor/github.com/openshift/api/*
cp -Rf * $dir/vendor/github.com/openshift/api/
rm -rf $dir/vendor/github.com/openshift/api/vendor
cp -Rf * $dir/api/
Copy link
Member

@dinhxuanvu dinhxuanvu May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not dir for /src/github.com/openshift/client-go/api so you may need to create one or do a temp one.

Copy link
Author

@soltysh soltysh May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or I can force to copy the entire current directory ./ rather than its contents * 😉

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@soltysh soltysh force-pushed the verify_api_clientgo branch from 91c6123 to 465f8cb Compare May 23, 2024 09:32
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2024

[REHEARSALNOTIFIER]
@soltysh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-api-master-verify-client-go openshift/api presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@soltysh
Copy link
Author

soltysh commented May 23, 2024

/pj-rehearse pull-ci-openshift-api-master-verify-client-go

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2024

@soltysh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@soltysh soltysh mentioned this pull request May 23, 2024
Merged
@soltysh
Copy link
Author

soltysh commented May 23, 2024

Once openshift/client-go#288 merges this will be good to go.

@soltysh
Copy link
Author

soltysh commented May 23, 2024

/pj-rehearse pull-ci-openshift-api-master-verify-client-go

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2024

@soltysh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@soltysh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@soltysh
Copy link
Author

soltysh commented May 23, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 23, 2024

/lgtm

dinhxuanvu
dinhxuanvu reviewed May 23, 2024
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soltysh
Copy link
Author

soltysh commented May 23, 2024

/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2024

@soltysh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 23, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, JoelSpeed, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7c31be0 into openshift:master May 23, 2024
@soltysh soltysh deleted the verify_api_clientgo branch May 23, 2024 12:44
@alebedev87 alebedev87 mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@knobunc knobunc Awaiting requested review from knobunc

1 more reviewer

@dinhxuanvu dinhxuanvu dinhxuanvu requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dinhxuanvu dinhxuanvu

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soltysh @dinhxuanvu @openshift-ci-robot @JoelSpeed