Skip to content

installer: remove references to Dockerfile.upi.ci.rhel8#50359

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
r4f4:installer-upi-ci-rhel8-remove
May 9, 2024
Merged

installer: remove references to Dockerfile.upi.ci.rhel8#50359
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
r4f4:installer-upi-ci-rhel8-remove

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Mar 28, 2024

That Dockerfile is just a symlink to Dockerfile.upi.ci and the "rhel8" suffix will soon stop making sense once we move the image to rhel9.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 28, 2024

/uncc @AnnaZivkovic

@openshift-ci openshift-ci bot removed the request for review from AnnaZivkovic March 28, 2024 17:11
@r4f4 r4f4 force-pushed the installer-upi-ci-rhel8-remove branch from 0a62c3c to 5c75891 Compare April 17, 2024 15:42
@r4f4
Copy link
Contributor Author

r4f4 commented Apr 17, 2024

/pj-rehearse pull-ci-openshift-installer-master-images

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 17, 2024

/pj-rehearse pull-ci-openshift-installer-master-okd-images pull-ci-openshift-installer-master-okd-scos-images

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 17, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 17, 2024
That Dockerfile is just a symlink to `Dockerfile.upi.ci` and the "rhel8"
suffix will soon stop making sense once we move the image to rhel9.
@r4f4 r4f4 force-pushed the installer-upi-ci-rhel8-remove branch from 5c75891 to 58720a8 Compare May 2, 2024 17:02
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 2, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@r4f4: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-okd-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-e2e-agent-ha-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-e2e-agent-sno-ipv6 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-e2e-gcp openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-e2e-gcp-ovn-upgrade openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-e2e-vsphere openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-scos-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-unit openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-okd-verify-codegen openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-agent-ha-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-agent-sno-ipv6 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-aws-ovn-upgrade openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-gcp openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-gcp-ovn-upgrade openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-e2e-vsphere openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-unit openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-okd-verify-codegen openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-agent-integration-tests openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-custom-security-groups openshift/installer presubmit Ci-operator config changed

A total of 362 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4
Copy link
Contributor Author

r4f4 commented May 2, 2024

/pj-rehearse pull-ci-openshift-installer-master-images pull-ci-openshift-installer-master-okd-images pull-ci-openshift-installer-master-okd-scos-images

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@r4f4
Copy link
Contributor Author

r4f4 commented May 2, 2024

okd-scos-images it's failing with a known issue introduced by openshift/installer#8326

@r4f4
Copy link
Contributor Author

r4f4 commented May 6, 2024

/pj-rehearse pull-ci-openshift-installer-master-images pull-ci-openshift-installer-master-okd-images pull-ci-openshift-installer-master-okd-scos-images

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/clusterimageset-validate 0a62c3c link true /test clusterimageset-validate
ci/rehearse/openshift/installer/master/okd-scos-images 58720a8 link unknown /pj-rehearse pull-ci-openshift-installer-master-okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented May 7, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 7, 2024
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eefda61 into openshift:master May 9, 2024
r4f4 added a commit to r4f4/installer that referenced this pull request May 9, 2024
This is now just a symlink to `Dockerfile.upi.ci` and it was first
created during the transition from rhel7 to rhel9. All our images are
now rhel9 based.

All the 4.16+ references to this symlink have been removed by
openshift/release#50359.
jbpratt pushed a commit to jbpratt/release that referenced this pull request May 30, 2024
)

That Dockerfile is just a symlink to `Dockerfile.upi.ci` and the "rhel8"
suffix will soon stop making sense once we move the image to rhel9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments