Skip to content

AGENT-863: fix oc dependency in installer images #8326

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
andfasano:agent-day2-fix-oc-dependency
Apr 29, 2024
Merged

AGENT-863: fix oc dependency in installer images #8326
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
andfasano:agent-day2-fix-oc-dependency

Conversation

@andfasano
Copy link
Contributor

This patch removes the explicit cli-artifacts dependency from the images to avoid introducing further complications in the build pipeline (see openshift-eng/ocp-build-data#4751), and switches the approach to directly install openshift-clients package just in the baremetal-installer image for retrieving the oc cli tool, required by node-joiner.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 29, 2024

@andfasano: This pull request references AGENT-863 which is a valid jira issue.

Details

In response to this:

This patch removes the explicit cli-artifacts dependency from the images to avoid introducing further complications in the build pipeline (see openshift-eng/ocp-build-data#4751), and switches the approach to directly install openshift-clients package just in the baremetal-installer image for retrieving the oc cli tool, required by node-joiner.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

andfasano commented Apr 29, 2024

cc @joepvd

@openshift-ci openshift-ci bot requested review from dtantsur and r4f4 April 29, 2024 13:58
joepvd added a commit to joepvd/ocp-build-data that referenced this pull request Apr 29, 2024
@joepvd
Copy link
Contributor

joepvd commented Apr 29, 2024

/lgtm

@andfasano
Copy link
Contributor Author

Requires openshift-eng/ocp-build-data#4757

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@r4f4
Copy link
Contributor

r4f4 commented Apr 29, 2024

/lgtm

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1a3d6c2 into openshift:master Apr 29, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-live-iso b13f921 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-metal-assisted b13f921 link false /test e2e-metal-assisted
ci/prow/okd-e2e-aws-ovn-upgrade b13f921 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-swapped-hosts b13f921 link false /test e2e-metal-ipi-ovn-swapped-hosts

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

thegreyd pushed a commit to openshift-eng/ocp-build-data that referenced this pull request Apr 29, 2024
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ocp-build-data that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants