use branched COSA for 4.14 and 4.15#47374
use branched COSA for 4.14 and 4.15#47374openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
When comparing to the openshift-os-release-4.13.yaml file there were clearly some spots in here where we should have been using the 4.14 of 4.15 instead of latest. This should make it so the CI doesn't pull the latest COSA which has caused test failures [1] because an iscsi test was recently added that won't pass in these older branches. [1] openshift/os#1414 (comment)
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
travier
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for catching that Dusty!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think we also need to update https://github.com/openshift/release/blob/036f9e148af3c4817f53b044d3c75ccaf7e2c8eb/core-services/image-mirroring/coreos/mapping_coreos_assembler_coreos_assembler to add 4.15. (Though honestly, I'm thinking we should drop that mirroring to make things simpler. But we need to make sure we're aware of all the users first though.) |
I'm not sure I follow.. The latest version of that file has 4.15 in it: |
|
From the tide status it looks like this PR needs the |
|
/label rehearsals-ack |
|
@dustymabe: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ahhh indeed, sorry for the noise. I think you're looking for: /pj-rehearse ack :) |
|
@dustymabe: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
When comparing to the openshift-os-release-4.13.yaml file there were clearly some spots in here where we should have been using the 4.14 of 4.15 instead of latest. This should make it so the CI doesn't pull the latest COSA which has caused test failures [1] because an iscsi test was recently added that won't pass in these older branches. [1] openshift/os#1414 (comment)
When comparing to the openshift-os-release-4.13.yaml file there were clearly some spots in here where we should have been using the 4.14 of 4.15 instead of latest.
This should make it so the CI doesn't pull the latest COSA which has caused test failures [1] because an iscsi test was recently added that won't pass in these older branches.
[1] openshift/os#1414 (comment)