Skip to content

use branched COSA for 4.14 and 4.15#47374

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
dustymabe:dusty-fix-cosa
Jan 8, 2024
Merged

use branched COSA for 4.14 and 4.15#47374
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
dustymabe:dusty-fix-cosa

Conversation

@dustymabe
Copy link
Copy Markdown
Member

When comparing to the openshift-os-release-4.13.yaml file there were clearly some spots in here where we should have been using the 4.14 of 4.15 instead of latest.

This should make it so the CI doesn't pull the latest COSA which has caused test failures [1] because an iscsi test was recently added that won't pass in these older branches.

[1] openshift/os#1414 (comment)

When comparing to the openshift-os-release-4.13.yaml file there were
clearly some spots in here where we should have been using the 4.14
of 4.15 instead of latest.

This should make it so the CI doesn't pull the latest COSA which has
caused test failures [1] because an iscsi test was recently added that
won't pass in these older branches.

[1] openshift/os#1414 (comment)
@openshift-ci openshift-ci bot requested review from aaradhak and c4rt0 January 6, 2024 02:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustymabe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-release-4.15-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.15-rhcos-92-build-test-metal openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.15-rhcos-92-build-test-qemu openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.15-validate openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.14-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.14-rhcos-92-build-test-metal openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.14-rhcos-92-build-test-qemu openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.14-validate openshift/os presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Copy Markdown
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for catching that Dusty!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 8, 2024

I think we also need to update https://github.com/openshift/release/blob/036f9e148af3c4817f53b044d3c75ccaf7e2c8eb/core-services/image-mirroring/coreos/mapping_coreos_assembler_coreos_assembler to add 4.15. (Though honestly, I'm thinking we should drop that mirroring to make things simpler. But we need to make sure we're aware of all the users first though.)

@dustymabe
Copy link
Copy Markdown
Member Author

I think we also need to update https://github.com/openshift/release/blob/036f9e148af3c4817f53b044d3c75ccaf7e2c8eb/core-services/image-mirroring/coreos/mapping_coreos_assembler_coreos_assembler to add 4.15. (Though honestly, I'm thinking we should drop that mirroring to make things simpler. But we need to make sure we're aware of all the users first though.)

I'm not sure I follow.. The latest version of that file has 4.15 in it:

quay.io/coreos-assembler/coreos-assembler:rhcos-4.15 registry.ci.openshift.org/coreos/coreos-assembler:4.15

@dustymabe
Copy link
Copy Markdown
Member Author

From the tide status it looks like this PR needs the rehearsals-ack label?

@dustymabe
Copy link
Copy Markdown
Member Author

/label rehearsals-ack

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 8, 2024

@dustymabe: The label(s) /label rehearsals-ack cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label rehearsals-ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 8, 2024

I think we also need to update 036f9e1/core-services/image-mirroring/coreos/mapping_coreos_assembler_coreos_assembler to add 4.15. (Though honestly, I'm thinking we should drop that mirroring to make things simpler. But we need to make sure we're aware of all the users first though.)

I'm not sure I follow.. The latest version of that file has 4.15 in it:

Ahhh indeed, sorry for the noise.

I think you're looking for:

/pj-rehearse ack

:)

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 8, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 8, 2024

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit da6e376 into openshift:master Jan 8, 2024
robpblake pushed a commit to robpblake/release that referenced this pull request Jan 11, 2024
When comparing to the openshift-os-release-4.13.yaml file there were
clearly some spots in here where we should have been using the 4.14
of 4.15 instead of latest.

This should make it so the CI doesn't pull the latest COSA which has
caused test failures [1] because an iscsi test was recently added that
won't pass in these older branches.

[1] openshift/os#1414 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants