Skip to content

[release-4.15] OCPBUGS-26228: overlay: include 40grub overlay from FCOS configs#1414

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.15from
dustymabe:dusty-bump-fcc-415
Jan 8, 2024
Merged

[release-4.15] OCPBUGS-26228: overlay: include 40grub overlay from FCOS configs#1414
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.15from
dustymabe:dusty-bump-fcc-415

Conversation

@dustymabe
Copy link
Copy Markdown
Member

overlay: include 40grub overlay from FCOS configs

See coreos/fedora-coreos-config#2769

This won't really have any effect right now but will enable someone
to use the generated ociarchive container images in the OSBuild
workflow that calls bootupctl with the --with-static-configs argument.

(cherry picked from commit 2771ca2)

```
$ git shortlog 5e9a9723f5e20c05c549efc01552614c4e824691..165eb7ea02e29590b988e23200d6d0cbbd26e5cd
Dusty Mabe (2):
      overlay.d: add 40grub overlay
      .cci.jenkinsfile: disable testing on older RHCOS branch
```
See coreos/fedora-coreos-config#2769

This won't really have any effect right now but will enable someone
to use the generated ociarchive container images in the OSBuild
workflow that calls bootupctl with the --with-static-configs argument.

(cherry picked from commit 2771ca2)
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 5, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@dustymabe: This pull request references Jira Issue OCPBUGS-26228, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26226 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-26226 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

overlay: include 40grub overlay from FCOS configs

See coreos/fedora-coreos-config#2769

This won't really have any effect right now but will enable someone
to use the generated ociarchive container images in the OSBuild
workflow that calls bootupctl with the --with-static-configs argument.

(cherry picked from commit 2771ca2)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@mike-nguyen
Copy link
Copy Markdown
Member

/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jan 5, 2024
@dustymabe
Copy link
Copy Markdown
Member Author

/retest

@mike-nguyen
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD a9796c3 and 2 for PR HEAD 1852ae2 in total

@dustymabe
Copy link
Copy Markdown
Member Author

CI is failing with

 Running test: iso-offline-install-iscsi.bios
FAIL: iso-offline-install-iscsi.bios (7m18.606s)
    QEMU exited; timed out waiting for completion 

but that test was just added in latest COSA not in 4.15

dustymabe added a commit to dustymabe/release that referenced this pull request Jan 6, 2024
When comparing to the openshift-os-release-4.13.yaml file there were
clearly some spots in here where we should have been using the 4.14
of 4.15 instead of latest.

This should make it so the CI doesn't pull the latest COSA which has
caused test failures [1] because an iscsi test was recently added that
won't pass in these older branches.

[1] openshift/os#1414 (comment)
openshift-merge-bot bot pushed a commit to openshift/release that referenced this pull request Jan 8, 2024
When comparing to the openshift-os-release-4.13.yaml file there were
clearly some spots in here where we should have been using the 4.14
of 4.15 instead of latest.

This should make it so the CI doesn't pull the latest COSA which has
caused test failures [1] because an iscsi test was recently added that
won't pass in these older branches.

[1] openshift/os#1414 (comment)
@mike-nguyen
Copy link
Copy Markdown
Member

/test rhcos-92-build-test-metal

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 8, 2024

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 477c816 into openshift:release-4.15 Jan 8, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@dustymabe: Jira Issue OCPBUGS-26228: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26228 has been moved to the MODIFIED state.

Details

In response to this:

overlay: include 40grub overlay from FCOS configs

See coreos/fedora-coreos-config#2769

This won't really have any effect right now but will enable someone
to use the generated ociarchive container images in the OSBuild
workflow that calls bootupctl with the --with-static-configs argument.

(cherry picked from commit 2771ca2)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

robpblake pushed a commit to robpblake/release that referenced this pull request Jan 11, 2024
When comparing to the openshift-os-release-4.13.yaml file there were
clearly some spots in here where we should have been using the 4.14
of 4.15 instead of latest.

This should make it so the CI doesn't pull the latest COSA which has
caused test failures [1] because an iscsi test was recently added that
won't pass in these older branches.

[1] openshift/os#1414 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants