Skip to content

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Dec 1, 2023

This is step 2 of 3 in the dance necessary to add e2e tests, adding the job definitions to utilise the e2e target added in openshift/cluster-api-provider-openstack#284. Our 3rd and final step will be to populate that e2e target with real stuff.

@openshift-ci openshift-ci bot requested review from EmilienM and dulek December 1, 2023 13:37
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@stephenfin
Copy link
Contributor Author

/assign @mdbooth
/cc @EmilienM
/cc @pierreprinetti

@stephenfin
Copy link
Contributor Author

/uncc @dulek

@openshift-ci openshift-ci bot removed the request for review from dulek December 1, 2023 13:38
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
Copy link
Contributor Author

Comments and linter issues addressed. Thanks for the review, @pierreprinetti!

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@stephenfin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-main-e2e-techpreview openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.15-e2e-techpreview openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.16-e2e-techpreview openshift/cluster-api-provider-openstack presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@EmilienM
Copy link
Member

EmilienM commented Dec 1, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Member

EmilienM commented Dec 1, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 900d4dc into openshift:master Dec 1, 2023
@EmilienM EmilienM deleted the capo-e2e-tests branch December 1, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants