-
Notifications
You must be signed in to change notification settings - Fork 2.1k
capo: Run e2e tets in openshift module #46310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capo: Run e2e tets in openshift module #46310
Conversation
|
/assign @mdbooth |
|
/uncc @dulek |
.../openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yaml
Outdated
Show resolved
Hide resolved
.../openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
adedc6c to
a9202c5
Compare
|
Comments and linter issues addressed. Thanks for the review, @pierreprinetti! |
a9202c5 to
c00f80c
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@stephenfin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is step 2 of 3 in the dance necessary to add e2e tests, adding the job definitions to utilise the
e2etarget added in openshift/cluster-api-provider-openstack#284. Our 3rd and final step will be to populate that e2e target with real stuff.