Skip to content

Conversation

@stephenfin
Copy link

What this PR does / why we need it:

This is step 1 of 3 in the dance necessary to add e2e tests. Next up, the job definition itself (in openshift/release).

Signed-off-by: Stephen Finucane stephenfin@redhat.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

n/a

Special notes for your reviewer:

n/a

TODOs:

n/a

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@openshift-ci openshift-ci bot requested review from gryf and mandre December 1, 2023 12:43
This is step 1 of 3 in the dance necessary to add e2e tests. Next up,
the job definition itself (in 'openshift/release').

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@stephenfin
Copy link
Author

/assign @mdbooth

@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2023

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member

EmilienM commented Dec 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@stephenfin
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@EmilienM
Copy link
Member

EmilienM commented Dec 1, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit becb402 into openshift:main Dec 1, 2023
@pierreprinetti pierreprinetti deleted the add-e2e-target branch December 1, 2023 15:07
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openstack-cluster-api-controllers-container-v4.15.0-202312011553.p0.gbecb402.assembly.stream for distgit openstack-cluster-api-controllers.
All builds following this will include this PR.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Unfortunately I tested on an existing cluster, which hat exactly this
token /o\
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants