Skip to content

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Jul 23, 2019

also switch auth console test job to use parameterized image template

also switch auth console test job to use parameterized image template
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2019
@bparees
Copy link
Contributor Author

bparees commented Jul 23, 2019

blocked on #4425

@bparees
Copy link
Contributor Author

bparees commented Jul 24, 2019

/retest

@bparees
Copy link
Contributor Author

bparees commented Jul 24, 2019

/test pj-rehearse

@bparees bparees changed the title [WIP] introduce parameterized test image template introduce parameterized test image template Jul 24, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2019
@bparees
Copy link
Contributor Author

bparees commented Jul 24, 2019

@spadgett @enj ptal, you're first into the breech on being converted to use a generic parameterized test image instead of a hardcoded one.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but @enj should probably review since it affects the cluster auth operator

@ecordell fyi

@abhinavdahiya
Copy link
Contributor

Why are we adding yet another template to create the cluster?

@bparees
Copy link
Contributor Author

bparees commented Jul 25, 2019

Why are we adding yet another template to create the cluster?

@abhinavdahiya we are adding a new template to control how tests are run against the cluster (via a parameterized image) so that teams can easily have jobs that are run against arbitrary repos, that will run their tests against PRs for those repos.

Once all the existing users of the console-specific template are updated to this, we can remove that template, so there will not be a net add of templates.

@bparees
Copy link
Contributor Author

bparees commented Jul 25, 2019

spoke w/ @enj on slack. applying lgtm label.

@stevekuznetsov @bbguimaraes can one of you approve?

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, spadgett, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit c0bc867 into openshift:master Jul 25, 2019
@openshift-ci-robot
Copy link
Contributor

@bparees: Updated the following 5 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-cluster-authentication-operator-master.yaml using file ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-cluster-authentication-operator-master.yaml using file ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-cluster-authentication-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master-presubmits.yaml
  • prow-job-cluster-launch-installer-custom-test-image configmap in namespace ci using the following files:
    • key cluster-launch-installer-custom-test-image.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-custom-test-image.yaml
  • prow-job-cluster-launch-installer-custom-test-image configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-custom-test-image.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-custom-test-image.yaml
Details

In response to this:

also switch auth console test job to use parameterized image template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees deleted the auth branch July 29, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants