-
Notifications
You must be signed in to change notification settings - Fork 2.1k
introduce parameterized test image template #4486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
also switch auth console test job to use parameterized image template
|
blocked on #4425 |
|
/retest |
|
/test pj-rehearse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Why are we adding yet another template to create the cluster? |
@abhinavdahiya we are adding a new template to control how tests are run against the cluster (via a parameterized image) so that teams can easily have jobs that are run against arbitrary repos, that will run their tests against PRs for those repos. Once all the existing users of the console-specific template are updated to this, we can remove that template, so there will not be a net add of templates. |
|
spoke w/ @enj on slack. applying lgtm label. @stevekuznetsov @bbguimaraes can one of you approve? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, spadgett, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bparees: Updated the following 5 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
also switch auth console test job to use parameterized image template