Skip to content

prepare for new parameterized test image job template #4425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 23, 2019
Merged

prepare for new parameterized test image job template #4425

openshift-merge-robot merged 1 commit into from
Jul 23, 2019

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Jul 18, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2019
stevekuznetsov
stevekuznetsov reviewed Jul 18, 2019
View reviewed changes
...nshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master.yaml Outdated
Copy link
Contributor

@stevekuznetsov stevekuznetsov Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer from as the key name to parallel the container test type and would not expect people to need to specify stable -- that's an internal detail

Copy link
Contributor Author

@bparees bparees Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you wish i guess, but i think my name choice offers more context to an inexperienced observer/reader of the file.

Copy link
Contributor Author

@bparees bparees Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated openshift/ci-tools#24 w/ this change, and updated this PR to reflect it.

ci-operator/templates/openshift/installer/cluster-launch-installer-console.yaml Outdated
Copy link
Contributor

@stevekuznetsov stevekuznetsov Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole thing should be resolved locally with image lookup, no?

Copy link
Contributor Author

@bparees bparees Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm?

@bparees
Copy link
Contributor Author

bparees commented Jul 18, 2019

/retest

1 similar comment
@bparees
Copy link
Contributor Author

bparees commented Jul 19, 2019

/retest

@bparees
Copy link
Contributor Author

bparees commented Jul 19, 2019

@stevekuznetsov i think you lied to me:

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_release/4425/rehearse-4425-pull-ci-openshift-cluster-authentication-operator-release-4.2-e2e-aws-console-login/1

template e2e-aws-console-login has required parameter TEST_IMAGESTREAM_TAG which is not defined

I can see the env var defined on the ci-operator pod:
https://gist.github.com/bparees/87b79ac3bc2508923ccb905980e44a71#file-gistfile1-txt-L89

but ci-operator does not seem to have passed it to the template as a parameter.

@bparees
Copy link
Contributor Author

bparees commented Jul 19, 2019

(Clayton did confirm this is supposed to work, so i'll dig in some more on what dots i may have failed to connect)

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 20, 2019 •
edited
Loading

@bparees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-authentication-operator/release-4.2/e2e-aws-console-login b390c250fb16568e12fd8312d194fe0e8a6bb017 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees bparees mentioned this pull request Jul 22, 2019
Merged
@bparees
Copy link
Contributor Author

bparees commented Jul 22, 2019

@stevekuznetsov ok i'm stuck again..I do not see why this is failing to provide the required parameter:

template e2e-aws-console-login has required parameter TEST_IMAGESTREAM_TAG which is not defined

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_release/4425/rehearse-4425-pull-ci-openshift-cluster-authentication-operator-release-4.2-e2e-aws-console-login/1

when i am clearly setting the env var here:
https://github.com/openshift/release/pull/4425/files#diff-c32b461cfc356aacc39cb76b517c2959R102

possible pj-rehearse bug?

@bparees
Copy link
Contributor Author

bparees commented Jul 23, 2019

/test pj-rehearse

@bparees bparees changed the title [DO_NOT_MERGE] parameterize console test job create a parameterized template for arbitrary test images Jul 23, 2019
@bparees bparees changed the title create a parameterized template for arbitrary test images prepare for new parameterized test image job template Jul 23, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2019
stevekuznetsov
stevekuznetsov reviewed Jul 23, 2019
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@bparees bparees mentioned this pull request Jul 23, 2019
Merged
@openshift-merge-robot openshift-merge-robot merged commit 1a9faf1 into openshift:master Jul 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 23, 2019

@bparees: Updated the plugins configmap in namespace ci using the following files:

  • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

depends on openshift/ci-tools#24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees deleted the parameterize branch July 25, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enj enj Awaiting requested review from enj

@ericavonb ericavonb Awaiting requested review from ericavonb

1 more reviewer

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bparees @openshift-ci-robot @stevekuznetsov @openshift-merge-robot