Skip to content

Conversation

@jianlinliu
Copy link
Contributor

Per openshift/installer#3065, openshift-install configmap can be used to determinate the install is a UPI or IPI install, while ipi-install-times-collection always create the configmap with the same name, so remove it avoid the conflicts.

@jianlinliu
Copy link
Contributor Author

cc @jianli-wei and @jinyunma to review.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianlinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.15-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-cluster-etcd-operator-release-4.14-e2e-gcp-qe-no-capabilities openshift/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-master-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.15-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.14-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-master-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-release-4.15-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-release-4.14-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.15-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.14-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-gcp-upi-baselinecaps-v411-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-vsphere-upi-disconnected-sdn-workers-rhcos-rhel8-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-nightly-4.11-upgrade-from-stable-4.10-aws-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-vsphere-8-upi-f14 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-vsphere-dis N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-vsphere-upi-disconnected-secureboot-fips-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-gcp-upi-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-vsphere-upi-disconnecting-network-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-gcp-upi-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-vsphere-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-gcp-upi-xpn-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-gcp-upi-xpn-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-4.12-upgrade-from-stable-4.11-aws-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-gcp-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-upi-disconnected-sdn-rhcos-rhel8-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-gcp-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-gcp-upi-xpn-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-vsphere-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-gcp-upi-xpn-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-4.11-upgrade-from-stable-4.11-gcp-upi-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-stable-4.9-gcp-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-vsphere-upi-disconnecting-network-f28 N/A periodic Registry content changed

A total of 159 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

@jianlinliu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@jianli-wei
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bc0a20c into openshift:master Sep 13, 2023
heyselbi pushed a commit to heyselbi/release that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants