Skip to content

skip CPMS check if UPI or SNO #43282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 18, 2023
Merged

skip CPMS check if UPI or SNO #43282

openshift-merge-robot merged 1 commit into from
Sep 18, 2023

Conversation

@jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Sep 13, 2023 •
edited
Loading

  • control plane machine set is available for IPI only, so skip the post-installation check for UPI or SNO tests

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@openshift-ci openshift-ci bot requested review from gpei and pruan-rht September 13, 2023 03:44
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 13, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 13, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-upi-f28

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 13, 2023

/retest-required

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 13, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 13, 2023

/retest-required

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 13, 2023

/retest-required

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 13, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianli-wei jianli-wei changed the title [WIP] skip CPMS check if UPI [WIP] skip CPMS check if UPI or SNP Sep 13, 2023
@jianli-wei jianli-wei changed the title [WIP] skip CPMS check if UPI or SNP skip CPMS check if UPI or SNP Sep 13, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@jianli-wei jianli-wei changed the title skip CPMS check if UPI or SNP skip CPMS check if UPI or SNO Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

@jianli-wei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-upi-f28 06f018347bba9b56c4e30f5b620b93477269aad6 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-upi-f28

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 13, 2023

/assign @jianlinliu @jinyunma @yunjiang29 please help review, thanks!

@jianli-wei jianli-wei force-pushed the gcp-cpms branch 3 times, most recently from a119621 to d5558a0 Compare September 14, 2023 10:23
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 14, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 14, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-gcp

@jinyunma
Copy link
Contributor

jinyunma commented Sep 15, 2023

@jianli-wei based on https://redhat-internal.slack.com/archives/CBN38N3MW/p1694685873609259?thread_ts=1694588019.759669&cid=CBN38N3MW, image used by step cucushift-installer-check-control-plane-machinesets maybe also need to be updated. cc @MayXuQQ

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 15, 2023 •
edited
Loading

@jianli-wei based on https://redhat-internal.slack.com/archives/CBN38N3MW/p1694685873609259?thread_ts=1694588019.759669&cid=CBN38N3MW, image used by step cucushift-installer-check-control-plane-machinesets maybe also need to be updated. cc @MayXuQQ

I guess we can use:

  from_image:
    namespace: ocp
    name: "4.13"
    tag: upi-installer

to meet both jq and oc cli requirement.

@jianli-wei jianli-wei force-pushed the gcp-cpms branch 2 times, most recently from d41e19c to 6820211 Compare September 18, 2023 05:02
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2023

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /var/tmp/gitrepo2563090041/ci-operator/step-registry/cucushift/installer/check/control-plane-machinesets/cucushift-installer-check-control-plane-machinesets-ref.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field "commands"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2023

[REHEARSALNOTIFIER]
@jianli-wei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-aws-ebs-csi-driver-operator-master-e2e-aws-csi-extended openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.15-e2e-aws-csi-extended openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.14-e2e-aws-csi-extended openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-main-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.15-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-gcp-filestore-csi-driver-operator-release-4.14-operator-e2e-extended openshift/gcp-filestore-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-disk-csi-driver-operator-master-e2e-azure-csi-extended openshift/azure-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-disk-csi-driver-operator-release-4.15-e2e-azure-csi-extended openshift/azure-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-disk-csi-driver-operator-release-4.14-e2e-azure-csi-extended openshift/azure-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-operator-master-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-operator-release-4.15-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-operator-release-4.14-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-operator-main-e2e-azure-file-csi-extended openshift/azure-file-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-operator-release-4.15-e2e-azure-file-csi-extended openshift/azure-file-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-operator-release-4.14-e2e-azure-file-csi-extended openshift/azure-file-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-master-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-release-4.15-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vsphere-problem-detector-release-4.14-e2e-vsphere-csi-extended openshift/vsphere-problem-detector presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-master-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.15-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-release-4.14-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-master-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.15-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-vmware-vsphere-csi-driver-operator-release-4.14-e2e-vsphere-csi-extended openshift/vmware-vsphere-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-master-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.15-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-release-4.14-e2e-aws-csi-extended openshift/aws-ebs-csi-driver presubmit Registry content changed
pull-ci-openshift-aws-efs-csi-driver-operator-master-operator-e2e-extended openshift/aws-efs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-efs-csi-driver-operator-release-4.15-operator-e2e-extended openshift/aws-efs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-efs-csi-driver-operator-release-4.14-operator-e2e-extended openshift/aws-efs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-master-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.15-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-ibm-vpc-block-csi-driver-release-4.14-e2e-ibmcloud-csi-extended openshift/ibm-vpc-block-csi-driver presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-master-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver presubmit Registry content changed
pull-ci-openshift-gcp-pd-csi-driver-release-4.15-e2e-gcp-csi-extended openshift/gcp-pd-csi-driver presubmit Registry content changed

A total of 2716 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Sep 18, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-gcp

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 18, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-4.14-upgrade-from-stable-4.13-azure-ipi-amd64-f14

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 18, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-gcp

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 18, 2023

/lgtm

@jianlinliu
Copy link
Contributor

jianlinliu commented Sep 18, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 415ebd4 into openshift:master Sep 18, 2023
@jianli-wei jianli-wei deleted the gcp-cpms branch September 18, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpei gpei Awaiting requested review from gpei

@pruan-rht pruan-rht Awaiting requested review from pruan-rht

1 more reviewer

@jianlinliu jianlinliu jianlinliu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jianlinliu jianlinliu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jianli-wei @jianlinliu @jinyunma @openshift-ci-robot @openshift-merge-robot