Skip to content

ci-operator/mco: rename mco dockerfile #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 10, 2019
Merged

ci-operator/mco: rename mco dockerfile #4314

openshift-merge-robot merged 1 commit into from
Jul 10, 2019

Conversation

@kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Jul 9, 2019 •
edited
Loading

Rename mco dockerfile from Dockerfile.machine-config-operator
to Dockerfile

Related-to: openshift/machine-config-operator#739
Required-by: openshift/machine-config-operator#895

cc:@runcom

@kikisdeliveryservice
ci-operator/mco: rename mco dockerfile
30029aa 
Rename mco dockerfile from Dockerfile.machine-config-operator
to Dockerfile

Related-to: openshift/machine-config-operator#739
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2019
@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Jul 9, 2019

This PR opened based on @runcom 's request here:
openshift/machine-config-operator#895 (comment)

/assign @runcom

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Jul 9, 2019
Merged
@kikisdeliveryservice kikisdeliveryservice changed the title ci-operator/mco: rename mco dockerfile WIP: ci-operator/mco: rename mco dockerfile Jul 9, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019
@kikisdeliveryservice kikisdeliveryservice changed the title WIP: ci-operator/mco: rename mco dockerfile ci-operator/mco: rename mco dockerfile Jul 9, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019
@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Jul 9, 2019

Realizing I need to change this first in our repo before I change it here, will have to time this correctly tomorrow.

So:
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2019
@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Jul 9, 2019 •
edited
Loading

In order to rename our new master dockerfile which is currently called Dockerfile.machine-config-operator to just Dockerfile but not break CI, I think I need to:

  1. add a dockerfile named Dockerfile to the MCO repo (this is just a copy of the current Dockerfile.machine-config-operator - our dockerfile that makes all of our images)
  2. merge this PR
  3. delete the old Dockerfile.machine-config-operator (the old master dockerfile containing all the component images)

@runcom
Copy link
Member

runcom commented Jul 9, 2019

last minute thought, this might be the time we sync with ART about the rhel image as well (if we drop Dockerfile.machine-config-operator.rhel7 will ART start failing?)

@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Jul 9, 2019

last minute thought, this might be the time we sync with ART about the rhel image as well (if we drop Dockerfile.machine-config-operator.rhel7 will ART start failing?)

@runcom Sounds like a good idea!! Will do!

kikisdeliveryservice added a commit to kikisdeliveryservice/machine-config-operator that referenced this pull request Jul 9, 2019
@kikisdeliveryservice
add new master Dockerfiles with finalized names
8ddc084 
The final mco master dockerfiles will be named:
Dockerfile and Dockerfile.rhel7 Need to ratchet in the name
change by first adding these files and copying contents of the
current master dockerfiles Dockerfile.machine-config-operator/.rhel7

Once this is is merged will be able to update the names in release
and ART in followup prs and remove all other Dockerfiles.

Related-to: openshift#739
Required-by: openshift/release#4314
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Jul 9, 2019
Merged
@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Jul 10, 2019 •
edited
Loading

lifting hold since openshift/machine-config-operator#941 has merged.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Jul 10, 2019
Closed
@runcom
Copy link
Member

runcom commented Jul 10, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2a81458 into openshift:master Jul 10, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 10, 2019

@kikisdeliveryservice: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.2-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-release-4.2.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.2.yaml
  • ci-operator-4.2-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-release-4.2.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.2.yaml
  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-release-4.3.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.3.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-release-4.3.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.3.yaml
Details

In response to this:

Rename mco dockerfile from Dockerfile.machine-config-operator
to Dockerfile

Related-to: openshift/machine-config-operator#739
Required-by: openshift/machine-config-operator#895

cc:@runcom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice deleted the rename-mco-dockerfile branch February 21, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

Assignees

@runcom runcom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kikisdeliveryservice @runcom @openshift-ci-robot @openshift-merge-robot