fold mco images/ ratchet: add new master Dockerfiles with finalized names #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final mco master dockerfiles will be named: Dockerfile and Dockerfile.rhel7 Need to ratchet in the name change by first adding these files and copying contents of the current master dockerfiles Dockerfile.machine-config-operator/.rhel7 Once this is is merged will be able to update the names in release and ART in followup prs and remove all other Dockerfiles. Related-to: openshift#739 Required-by: openshift/release#4314
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
reviewed
Jul 9, 2019
cgwalters
reviewed
Jul 9, 2019
Contributor
Author
|
/retest |
This was referenced Jul 10, 2019
sosiouxme
pushed a commit
to openshift-eng/ocp-build-data
that referenced
this pull request
Jul 18, 2019
The MCO is updating its dockerfiles to use 1 super dockerfile that replaces exisiting individual mcc/mcd/mco/mcs/setupetcdenv dockerfiles. PR removes individual componenent ose...yml files and renames Dockerfile.machine-config-operator.rhel7 to Dockerfile.rhel7 Related-to: github.com/openshift/machine-config-operator/issues/739 Required-by: github.com/openshift/machine-config-operator/pull/941
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final mco master dockerfiles will be named:
Dockerfile and Dockerfile.rhel7 We need to ratchet in the name
change by first adding these files and copying contents of the
current master dockerfiles Dockerfile.machine-config-operator/.rhel7
Once this is is merged will be able to update the names in release
and ART in followup prs and remove all other Dockerfiles.
Related-to: #739
Related-to: #894
Required-by: openshift/release#4314