Skip to content

OpenStack: Add compact cluster job to installer pre-submit#41564

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:nfv-openstack-installer
Jul 28, 2023
Merged

OpenStack: Add compact cluster job to installer pre-submit#41564
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:nfv-openstack-installer

Conversation

@mandre
Copy link
Member

@mandre mandre commented Jul 24, 2023

Add the e2e-openstack-nfv-intel job to the active branches for the installer repo to validate the compact cluster deployment. This job gets triggered when modifying openstack-specific code, and is non-blocking.

@mandre
OpenStack: Add compact cluster job to installer pre-submit
eb042a8 
Add the `e2e-openstack-nfv-intel` job to the active branches for the
installer repo to validate the compact cluster deployment. This job gets
triggered when modifying openstack-specific code, and is non-blocking.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2023

[REHEARSALNOTIFIER]
@mandre: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-openstack-nfv-intel openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.10-e2e-openstack-nfv-intel openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.11-e2e-openstack-nfv-intel openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.12-e2e-openstack-nfv-intel openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.13-e2e-openstack-nfv-intel openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.14-e2e-openstack-nfv-intel openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.15-e2e-openstack-nfv-intel openshift/installer presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mandre mandre mentioned this pull request Jul 24, 2023
Merged
@mandre
Copy link
Member Author

mandre commented Jul 24, 2023

/pj-rehearse pull-ci-openshift-installer-master-e2e-openstack-nfv-intel

@mandre
Copy link
Member Author

mandre commented Jul 24, 2023

OK, this shows that my patch at openshift/installer#7356 was not enough to fix the job.

However, the job does what it is supposed to, let's merge it to make fixing compact clusters on openstack easier.

/pj-rehearse ack
/assign @sadasu

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 24, 2023
@mandre mandre mentioned this pull request Jul 24, 2023
Merged
@dulek
Copy link
Contributor

dulek commented Jul 25, 2023

/lgtm

Job fails as expected without openshift/installer#7359.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@EmilienM
Copy link
Member

EmilienM commented Jul 27, 2023 •
edited
Loading

/pj-rehearse reject

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 27, 2023
@EmilienM
Copy link
Member

EmilienM commented Jul 27, 2023

/pj-rehearse ack
sorry I thought you wanted the installer PR to land first.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023

@mandre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/master/e2e-openstack-nfv-intel eb042a8 link unknown /pj-rehearse pull-ci-openshift-installer-master-e2e-openstack-nfv-intel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

r4f4
r4f4 reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/aprove

@r4f4
Copy link
Contributor

r4f4 commented Jul 28, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, EmilienM, mandre, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit ec12a0e into openshift:master Jul 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

@mandre: Updated the following 14 configmaps:

  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.12.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.12.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.14.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.14.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.14-presubmits.yaml
  • job-config-4.15 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.15-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.15-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.10.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.10.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.13.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.13.yaml
  • job-config-4.10 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.10-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.10-presubmits.yaml
  • job-config-4.11 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.11-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.11-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.13-presubmits.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.11.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.11.yaml
  • ci-operator-4.15-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.15.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.15.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.12-presubmits.yaml
Details

In response to this:

Add the e2e-openstack-nfv-intel job to the active branches for the installer repo to validate the compact cluster deployment. This job gets triggered when modifying openstack-specific code, and is non-blocking.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM deleted the nfv-openstack-installer branch July 28, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

1 more reviewer

@r4f4 r4f4 r4f4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dulek dulek

@EmilienM EmilienM

@sadasu sadasu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mandre @openshift-ci-robot @dulek @EmilienM @r4f4 @sadasu @openshift-merge-robot