Skip to content

OpenStack: Fix default for openstack_worker_server_group_names#7359

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:openstack-compact-cluster
Jul 30, 2023
Merged

OpenStack: Fix default for openstack_worker_server_group_names#7359
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:openstack-compact-cluster

Conversation

@mandre
Copy link
Member

@mandre mandre commented Jul 24, 2023

A follow-up to #7356.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mandre
Copy link
Member Author

mandre commented Jul 24, 2023

/hold
Waiting for openshift/release#41564 to be able to test.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@dulek dulek mentioned this pull request Jul 25, 2023
Merged
@EmilienM
Copy link
Member

EmilienM commented Jul 26, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@mandre mandre marked this pull request as ready for review July 28, 2023 01:25
@mandre
Copy link
Member Author

mandre commented Jul 28, 2023

/hold

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2023
@openshift-ci openshift-ci bot requested review from dulek and stephenfin July 28, 2023 01:27
@EmilienM
Copy link
Member

EmilienM commented Jul 28, 2023

/test e2e-openstack-nfv-intel

@EmilienM
Copy link
Member

EmilienM commented Jul 28, 2023

/retest-required

@EmilienM
Copy link
Member

EmilienM commented Jul 29, 2023 

{  Downloading current MachineSet for workers
No resources found in openshift-machine-api namespace.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/7359/pull-ci-openshift-installer-master-e2e-openstack-nfv-intel/1684961780448628736

@EmilienM EmilienM force-pushed the openstack-compact-cluster branch from fcf9eb7 to e502c4c Compare July 29, 2023 17:59
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2023
@EmilienM
Copy link
Member

EmilienM commented Jul 29, 2023

/test e2e-openstack-nfv-intel

@EmilienM
Copy link
Member

EmilienM commented Jul 30, 2023

/lgtm
/hold cancel
/test okd-images

The error in is e2e-openstack-nfv-intel not related to the PR, and we need this patch anyway.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 30, 2023
@EmilienM EmilienM mentioned this pull request Jul 30, 2023
Merged
7 tasks
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2023

/retest-required

Remaining retests: 0 against base HEAD 66cc2e5 and 2 for PR HEAD e502c4c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2023

@mandre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-intel e502c4c link false /test e2e-openstack-nfv-intel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e044bf5 into openshift:master Jul 30, 2023
@EmilienM EmilienM deleted the openstack-compact-cluster branch July 30, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulek dulek Awaiting requested review from dulek

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mandre @EmilienM @openshift-ci-robot @openshift-merge-robot