OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11, 4.12, 4.13 [old]#40963
OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11, 4.12, 4.13 [old]#40963ricky-rav wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit |
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.12-unit |
|
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.11-unit |
|
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.10-unit |
c8215dd to
85791f4
Compare
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit |
|
@ricky-rav, |
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Apply to YAMLs for 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca. We added a new package called: github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574. Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently. So what happens is: PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running. This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
85791f4 to
df15064
Compare
|
/jira refresh /pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit |
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Unit tests fail on 4.13, 4.12 and 4.11:
I'll have to fix these issues before this PR can be merged. |
|
Uhm... I have the impression that CI is not picking the latest commit in the respective ovn-kubernetes branches... The unit test that fails in 4.13 doesn't fail if I run it on my pc. As for 4.12 and 4.11, the fix was already merged in July: openshift/ovn-kubernetes#1739, so it's definitely using older code... perhaps the latest commit when I opened this release PR? |
|
Closing this in favor of #43491 |
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-15716. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Apply to YAMLs for 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca (#39835)
We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.
Since then we have not been running UTs because the parser breaks as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.
So what happens is:
results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.
This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.