Skip to content

OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11, 4.12, 4.13 [old]#40963

Closed
ricky-rav wants to merge 1 commit intoopenshift:masterfrom
ricky-rav:enableDownstreamUT
Closed

OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11, 4.12, 4.13 [old]#40963
ricky-rav wants to merge 1 commit intoopenshift:masterfrom
ricky-rav:enableDownstreamUT

Conversation

@ricky-rav
Copy link
Contributor

@ricky-rav ricky-rav commented Jul 5, 2023

Apply to YAMLs for 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca (#39835)

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser breaks as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 5, 2023
@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Apply to YAMLs for 4.10, 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca.

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:
PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Apply to YAMLs for 4.10, 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca.

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from JacobTanenbaum and tssurya July 5, 2023 09:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricky-rav
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricky-rav
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 5, 2023
@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter July 5, 2023 09:02
@ricky-rav
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.12-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.11-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.10-unit

@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Apply to YAMLs for 4.10, 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca (#39835)

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricky-rav
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.12-unit

@ricky-rav
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.11-unit

@ricky-rav
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.10-unit

@ricky-rav ricky-rav force-pushed the enableDownstreamUT branch from c8215dd to 85791f4 Compare July 5, 2023 14:44
@ricky-rav ricky-rav changed the title OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.10->4.13 OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11->4.13 Jul 5, 2023
@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Apply to YAMLs for 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca (#39835)

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricky-rav ricky-rav changed the title OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11->4.13 OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11, 4.12, 4.13 Jul 5, 2023
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2023
@ricky-rav
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.12-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.11-unit

@openshift-ci-robot
Copy link
Contributor

@ricky-rav, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase repo client

@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Apply to YAMLs for 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca (#39835)

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser breaks as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Apply to YAMLs for 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca.

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching
starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser
gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util
currently.

So what happens is:
PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs)
PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ }
PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to
stat /batching: directory not found thus blocking the UTs from
running.

This PR fixes this by escaping util/batching as well. If we want to
enable this in the future we can do that, for now fixing the
introduced regression in tests.

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@ricky-rav
Copy link
Contributor Author

/jira refresh

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.12-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.11-unit

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.12-unit
/pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.11-unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ricky-rav: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ovn-kubernetes-release-4.13-unit openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.12-unit openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.11-unit openshift/ovn-kubernetes presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@ricky-rav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/ovn-kubernetes/release-4.10/unit c8215dddee460b70b16ade3ab733f964589d393c link unknown /pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.10-unit
ci/rehearse/openshift/ovn-kubernetes/release-4.11/unit c8215dddee460b70b16ade3ab733f964589d393c link unknown /pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.11-unit
ci/rehearse/openshift/ovn-kubernetes/release-4.12/unit c8215dddee460b70b16ade3ab733f964589d393c link unknown /pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.12-unit
ci/rehearse/openshift/ovn-kubernetes/release-4.13/unit df15064 link unknown /pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.13-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ricky-rav
Copy link
Contributor Author

Unit tests fail on 4.13, 4.12 and 4.11:

• Failure [0.114 seconds]
Node Operations
/go/src/github.com/openshift/ovn-kubernetes/go-controller/pkg/node/gateway_localnet_linux_test.go:219
  on add
  /go/src/github.com/openshift/ovn-kubernetes/go-controller/pkg/node/gateway_localnet_linux_test.go:377
    inits iptables rules and openflows with LoadBalancer where AllocateLoadBalancerNodePorts=False, ETP=local, LGW mode [It]
    /go/src/github.com/openshift/ovn-kubernetes/go-controller/pkg/node/gateway_localnet_linux_test.go:837
    Expected success, but got an error:
              
        <*errors.errorString | 0xc0000ee480>: {
            s: "expected rule \"-p TCP -d 10.244.0.3 --dport 8080 -j RETURN\" at pos 0 in chain nat/OVN-KUBE-SNAT-MGMTPORT, got \"-p TCP -d 10.244.0.4 --dport 8080 -j RETURN\"",
        }
        expected rule "-p TCP -d 10.244.0.3 --dport 8080 -j RETURN" at pos 0 in chain nat/OVN-KUBE-SNAT-MGMTPORT, got "-p TCP -d 10.244.0.4 --dport 8080 -j RETURN"
    /go/src/github.com/openshift/ovn-kubernetes/go-controller/pkg/node/gateway_localnet_linux_test.go:957
go test -mod=vendor -test.v -race  github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops 
# github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops [github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops.test]
pkg/libovsdbops/acl_test.go:98:15: undefined: FindACLs
pkg/libovsdbops/acl_test.go:105:15: undefined: UpdateACLsOps
FAIL	github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops [build failed]
FAIL
go test -mod=vendor -test.v -race  github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops 
# github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops [github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops.test]
pkg/libovsdbops/acl_test.go:98:15: undefined: FindACLs
pkg/libovsdbops/acl_test.go:105:15: undefined: UpdateACLsOps
FAIL	github.com/ovn-org/ovn-kubernetes/go-controller/pkg/libovsdbops [build failed]
FAIL
make: *** [test] Error 2

I'll have to fix these issues before this PR can be merged.

@ricky-rav
Copy link
Contributor Author

Uhm... I have the impression that CI is not picking the latest commit in the respective ovn-kubernetes branches...

The unit test that fails in 4.13 doesn't fail if I run it on my pc.

As for 4.12 and 4.11, the fix was already merged in July: openshift/ovn-kubernetes#1739, so it's definitely using older code... perhaps the latest commit when I opened this release PR?

@ricky-rav ricky-rav changed the title OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11, 4.12, 4.13 OCPBUGS-15716: OVNK: UTs: Escape batching package tests in 4.11, 4.12, 4.13 [old] Sep 19, 2023
@ricky-rav
Copy link
Contributor Author

Closing this in favor of #43491
Somehow it kept picking the latest commit of openshift/ovn-kubernets from when /this/ release PR was opened. Go figure.

@ricky-rav ricky-rav closed this Sep 19, 2023
@openshift-ci-robot
Copy link
Contributor

@ricky-rav: This pull request references Jira Issue OCPBUGS-15716. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Apply to YAMLs for 4.11, 4.12, 4.13 the fix for running unit tests downstream that was merged for master branch with commit 42124ca (#39835)

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser breaks as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs) PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ } PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing "/batching" which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants