OCPBUGS-14248: OVNK: UTs: Escape batching package tests

[tssurya]

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs)
PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ }
PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing /batching which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@tssurya: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-ovn-kubernetes-master-unit	openshift/ovn-kubernetes	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[tssurya]

/pj-rehearse

[openshift-ci-robot]

@tssurya: This pull request references Jira Issue OCPBUGS-14248, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs)
PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ }
PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing /batching which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tssurya]

/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-unit

[tssurya]

/rehearsals-ack

[tssurya]

/pj-rehearse ack

[tssurya]

/hold

[abhat]

/lgtm

[abhat]

/approve
/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/ovn-kubernetes/OWNERS [abhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tssurya: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@tssurya: Jira Issue OCPBUGS-14248: All pull requests linked via external trackers have merged:

• openshift/release#39835

Jira Issue OCPBUGS-14248 has been moved to the MODIFIED state.

Details

In response to this:

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs)
PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ }
PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing /batching which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@tssurya: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

• key openshift-ovn-kubernetes-master.yaml using file ci-operator/config/openshift/ovn-kubernetes/openshift-ovn-kubernetes-master.yaml

Details

In response to this:

We added a new package called:
github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util/batching starting in openshift/ovn-kubernetes#1574.

Since then we have not been running UTs because the parser gets screwed as we escape on github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util currently.

So what happens is:

PKGS=$(go list -mod vendor -f '{{if len .TestGoFiles}} {{.ImportPath}} {{end}}' ${PKGS:-./cmd/... ./pkg/... ./hybrid-overlay/...} | xargs)
PKGS=${PKGS//"github.com/ovn-org/ovn-kubernetes/go-controller/pkg/util"/ }
PKGS=$PKGS make test NOROOT=TRUE

results in value of PKGS containing /batching which leads to stat /batching: directory not found thus blocking the UTs from running.

This PR fixes this by escaping util/batching as well. If we want to enable this in the future we can do that, for now fixing the introduced regression in tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tssurya]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@tssurya: cannot checkout release-4.13: error checking out release-4.13: exit status 1. output: error: pathspec 'release-4.13' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.