HOSTEDCP-966: Gate more Operators on Hypeshift e2e #39246
Conversation
enxebre
changed the title
|
@enxebre: This pull request references HOSTEDCP-966 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
I don't know why I was picked up as a reviewer for this PR, seems to be a bug from Prow/Github 🤔 |
enxebre
force-pushed
the
gate-more-operator-on-hypershift
branch
from
42a4032 to
6551635
Compare
|
/pj-rehearse |
|
/lgtm |
enxebre
force-pushed
the
gate-more-operator-on-hypershift
branch
from
6551635 to
f6d860f
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/lgtm |
| container: | ||
| from: src | ||
| - as: e2e-hypershift | ||
| steps: |
There was a problem hiding this comment.
Could we add optional: true until we know this doesn't introduce any issues for cluster-ingress-operator CI?
There was a problem hiding this comment.
We are actually intentionally setting it as not optional at this point given we're GAing to prevent operators from breaking us at it has happened in the past.
We are doing the same in multiple operators and we are also ci stream promotion blocker now. I think it's a fair organic step and we can always relax it back if it cause unncessary issues. Makes sense?
There was a problem hiding this comment.
This is the newest example openshift/cluster-ingress-operator#930 where this could have been very valuable.
We need to get this merged asap right after fixing this new issue so teams are able to operate with healthy safety checks that ensure GA level stability.
|
/approve Super important. @enxebre just rehersal ack when you're happy with the results. The revert is on it's way, being forced in. |
|
Revert merged openshift/cluster-ingress-operator#938 |
I assume that was still using conflicting code /pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, enxebre, kpouget, Miciah, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
Nope a different break openshift/cluster-openshift-controller-manager-operator#288 and openshift/route-controller-manager#22 |
|
@enxebre: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@enxebre: Updated the following 2 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
10 participants
No description provided.