Revert "OCPBUGS-6661, OCPBUGS-9464: Move mTLS CRL handling into the router, and fix accidental duplication of CRLs"

[dgoodwin]

Reverts #930 ; tracked by https://issues.redhat.com//browse/OCPBUGS-9464

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

• This change is breaking ci 4.14 payloads
  • https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-05-23-151600

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

Although the team already has a PR open to get hypershift as a presubmit on this repo, which we will also prioritize merging.

CC: @rfredette @enxebre @Miciah

[openshift-ci-robot]

@dgoodwin: This pull request references Jira Issue OCPBUGS-9464, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #930 ; tracked by OCPBUGS-14019

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

• This change is breaking ci 4.14 payloads
• https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-05-23-151600

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

Although the team already has a PR open to get hypershift as a presubmit on this repo, which we will also prioritize merging.

CC: @rfredette @enxebre @Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[DennisPeriquet]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dgoodwin]

Per policy given the hypershift teams confidence this is the cause of the breakage, I will force merge this as we're going back to a known good state.

/label approved
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-azure-operator
/override ci/prow/e2e-azure-ovn
/override ci/prow/e2e-gcp-operator
/override ci/prow/e2e-gcp-ovn

[openshift-ci]

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-operator, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-azure-operator, ci/prow/e2e-azure-ovn, ci/prow/e2e-gcp-operator, ci/prow/e2e-gcp-ovn

Details

In response to this:

Per policy given the hypershift teams confidence this is the cause of the breakage, I will force merge this as we're going back to a known good state.

/label approved
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-azure-operator
/override ci/prow/e2e-azure-ovn
/override ci/prow/e2e-gcp-operator
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dgoodwin]

/jira refresh

[openshift-ci-robot]

@dgoodwin: This pull request references Jira Issue OCPBUGS-9464, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@dgoodwin: This pull request references Jira Issue OCPBUGS-9464, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Reverts #930 ; tracked by https://issues.redhat.com//browse/OCPBUGS-9464

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

• This change is breaking ci 4.14 payloads
• https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-05-23-151600

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

Although the team already has a PR open to get hypershift as a presubmit on this repo, which we will also prioritize merging.

CC: @rfredette @enxebre @Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@dgoodwin: Jira Issue OCPBUGS-9464: All pull requests linked via external trackers have merged:

• openshift/router#472
• openshift/cluster-ingress-operator#930
• openshift/cluster-ingress-operator#938

Jira Issue OCPBUGS-9464 has been moved to the MODIFIED state.

Details

In response to this:

Reverts #930 ; tracked by https://issues.redhat.com//browse/OCPBUGS-9464

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

• This change is breaking ci 4.14 payloads
• https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-05-23-151600

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

Although the team already has a PR open to get hypershift as a presubmit on this repo, which we will also prioritize merging.

CC: @rfredette @enxebre @Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.