Skip to content

always use tag name for release image when mirroring #35803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 29, 2023
Merged

always use tag name for release image when mirroring #35803

openshift-merge-robot merged 1 commit into from
Jan 29, 2023

Conversation

@jianlinliu
Copy link
Contributor

@jianlinliu jianlinliu commented Jan 28, 2023 •
edited
Loading

ensure mirror release image by tag name, refer to openshift/oc#1331

@openshift-ci openshift-ci bot requested a review from bbguimaraes January 28, 2023 07:59
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 28, 2023

@jianlinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-azure-ipi-disconnected-fullyprivate-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-c2s-ipi-disconnected-private-p2-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-stable-gcp-ipi-disconnected-workers-rhel8-p2-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-nightly-gcp-ipi-disconnected-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-aws-ipi-disconnected-private-sno-baselinecaps-none-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-stable-aws-ipi-disconnected-private-sno-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-azure-ipi-disconnected-fullyprivate-tp-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-stable-aws-ipi-disconnected-private-techpreview-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-aws-ipi-disconnected-cco-manual-sts-ep-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-usgov-ipi-disconnected-private-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-disconnected-cco-manual-sts-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-stable-aws-ipi-disconnected-cco-manual-sts-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-nightly-aws-ipi-disconnected-workers-rhcos-rhel8-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-stable-aws-ipi-disconnected-private-sno-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-nightly-aws-ipi-disconnected-private-techpreview-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-disconnected-private-sno-baselinecaps-none-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-stable-aws-ipi-disconnected-private-p2-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-4.12-upgrade-from-stable-4.11-aws-ipi-disconnected-cco-manual-sts-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-azure-ipi-disconnected-fullyprivate-tp-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-disconnected-private-sno-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-azure-ipi-disconnected-p1-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-stable-gcp-ipi-disconnected-private-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-usgov-ipi-disconnected-private-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-stable-gcp-ipi-disconnected-p2-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-gcp-ipi-disconnected-private-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-gcp N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-nightly-azure-ipi-disconnected-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.8-amd64-nightly-aws-c2s-ipi-disconnected-private-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-gcp-ipi-disconnected-private-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-disconnected-workers-rhcos-rhel8-p2-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-azure-ipi-disconnected-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.9-amd64-nightly-aws-ipi-disconnected-workers-rhcos-rhel8-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-disconnected-workers-rhcos-rhel8-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-4.12-upgrade-from-stable-4.11-aws-ipi-disconnected-private-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-aws-ipi-disconnected-private-sno-p3-f28-destructive N/A periodic Registry content changed

A total of 357 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested a review from hongkailiu January 28, 2023 07:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2023
@jianlinliu
Copy link
Contributor Author

jianlinliu commented Jan 28, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-gcp

1 similar comment
@jianlinliu
Copy link
Contributor Author

jianlinliu commented Jan 28, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-gcp

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Jan 28, 2023

cc @yunjiang29 and @LiZhang19817 for review.

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Jan 28, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.10-installer-rehearse-aws

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Jan 28, 2023

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.10-installer-rehearse-vsphere-discon

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2023

@jianlinliu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-gcp 295f716b9819e07f9d36f3ed2945e15f5c9ee0d5 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Jan 29, 2023

@jinyunma can you help review and approve it?

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Jan 29, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 29, 2023
@jinyunma
Copy link
Contributor

jinyunma commented Jan 29, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, jinyunma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 65c3abf into openshift:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@jinyunma jinyunma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jianlinliu @openshift-ci-robot @jinyunma @openshift-merge-robot