pkg/cli/admin/release/mirror: Reject by-digest --to-release-image pullspecs #1331
Conversation
…lspecs 'oc adm release mirror ...' should tag both the main release image and all the referenced component images when it pushes to the registry. Ideally all downstream consumers are using by-digest pullspecs, because those are immutable, and therefore safer, as described in 43cb3c8 (pkg/cli/admin/upgrade: Client-side by-tag guard, 2020-04-16, openshift#390). But many image registries garbage-collect untagged images, so when we push into a registry we need to push into a tag to avoid that garbage collection.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 participants
oc adm release mirror ...should tag both the main release image and all the referenced component images when it pushes to the registry. Ideally all downstream consumers are using by-digest pullspecs, because those are immutable, and therefore safer, as described in 43cb3c8 (#390). But many image registries garbage-collect untagged images, so when we push into a registry we need to push into a tag to avoid that garbage collection.