Skip to content

MCO: add a verify command in ci #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 3, 2019
Merged

MCO: add a verify command in ci #3332

openshift-merge-robot merged 1 commit into from
Apr 3, 2019

Conversation

@runcom
Copy link
Member

@runcom runcom commented Apr 2, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2019
@runcom runcom mentioned this pull request Apr 2, 2019
Merged
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2019
@runcom
Copy link
Member Author

runcom commented Apr 2, 2019 •
edited
Loading

The first failure we're getting is because we need openshift/machine-config-operator#595 to change the make verify target to NOT run tests. Afterwards, when that's merged, the other failure we'll get will come from openshift/machine-config-operator#596 and after that merges, this should be green and ready to finally merge no longer the case

@runcom
Copy link
Member Author

runcom commented Apr 2, 2019

/hold

see #3332 (comment)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2019
@runcom
Copy link
Member Author

runcom commented Apr 3, 2019

/hold cancel

deps have merged, let's see if this works here now

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2019
@runcom
Copy link
Member Author

runcom commented Apr 3, 2019

ok this needs another tweak in the mco script that this new job executes

@runcom
Copy link
Member Author

runcom commented Apr 3, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2019
@runcom runcom mentioned this pull request Apr 3, 2019
Merged
@runcom
Copy link
Member Author

runcom commented Apr 3, 2019 •
edited
Loading

fix here openshift/machine-config-operator#598 merged

@LorbusChris
Copy link
Contributor

LorbusChris commented Apr 3, 2019

/retest

@runcom
Copy link
Member Author

runcom commented Apr 3, 2019 •
edited
Loading

cool cool, it's green now (even the MCO actual new job) and it can be merged so mco has this new job

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2019
@runcom
MCO: add a verify command in ci
ee45fce 
Signed-off-by: Antonio Murdaca <[email protected]>
@runcom runcom mentioned this pull request Apr 3, 2019
Merged
@LorbusChris
Copy link
Contributor

LorbusChris commented Apr 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bfafdf0 into openshift:master Apr 3, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2019

@runcom: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • job-config-master configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
Details

In response to this:

Signed-off-by: Antonio Murdaca [email protected]

@cgwalters @stevekuznetsov ptal

need openshift/machine-config-operator#595 first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom runcom deleted the mco-verify branch April 3, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@LorbusChris LorbusChris

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@runcom @LorbusChris @openshift-ci-robot @openshift-merge-robot