Skip to content

Conversation

@aleskandro
Copy link
Member

Hi @deepsm007, as of #32969, for the arm64 arch, the default node types for AWS IPI are set to m6g.xlarge when the cluster architecture (or the cluster profile) is arm64.

Would you check in this PR to remove it from the CI jobs?

/cc @deepsm007

@openshift-ci openshift-ci bot requested a review from deepsm007 October 10, 2022 10:37
@aleskandro
Copy link
Member Author

/hold
until #31965 is merged to avoid rebasing it

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@aleskandro aleskandro force-pushed the default-worker-type-arm64-ma branch from 577c583 to d1e12d3 Compare October 17, 2022 06:30
@aleskandro
Copy link
Member Author

Hi @deepsm007 we'd be able to merge this now.

@aleskandro
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@deepsm007
Copy link
Contributor

/lgtm
/hold remove the hold when test passes

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2022
@aleskandro
Copy link
Member Author

Thanks @deepsm007 as there are some failures, could you double confirm that they are not related to the changes introduced by this PR?

@deepsm007
Copy link
Contributor

/unhold
The failing tests are known issues not related to PR changes, alerts for KubeApiBudgetBurn and events should not repeat pathological

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

@aleskandro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-aws-arm64-techpreview 577c5839055dcd1373c8dfd3306618de0622e96e link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-serial-aws-arm64 d1e12d3 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-upgrade-aws-arm64 d1e12d3 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.12-ocp-e2e-sdn-serial-aws-arm64 d1e12d3 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit eb598fe into openshift:master Oct 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

@aleskandro: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-multiarch-master__nightly-4.11.yaml using file ci-operator/config/openshift/multiarch/openshift-multiarch-master__nightly-4.11.yaml
  • key openshift-multiarch-master__nightly-4.12.yaml using file ci-operator/config/openshift/multiarch/openshift-multiarch-master__nightly-4.12.yaml
Details

In response to this:

Hi @deepsm007, as of #32969, for the arm64 arch, the default node types for AWS IPI are set to m6g.xlarge when the cluster architecture (or the cluster profile) is arm64.

Would you check in this PR to remove it from the CI jobs?

/cc @deepsm007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aleskandro aleskandro deleted the default-worker-type-arm64-ma branch December 19, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants