-
Notifications
You must be signed in to change notification settings - Fork 2.1k
No need to set compute_node_type in arm64 jobs anymore #32977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No need to set compute_node_type in arm64 jobs anymore #32977
Conversation
|
/hold |
577c583 to
d1e12d3
Compare
|
Hi @deepsm007 we'd be able to merge this now. |
|
/unhold |
|
/lgtm |
|
Thanks @deepsm007 as there are some failures, could you double confirm that they are not related to the changes introduced by this PR? |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aleskandro: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@aleskandro: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @deepsm007, as of #32969, for the arm64 arch, the default node types for AWS IPI are set to
m6g.xlargewhen the cluster architecture (or the cluster profile) isarm64.Would you check in this PR to remove it from the CI jobs?
/cc @deepsm007