-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Default worker type for aws on arm64 #32969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default worker type for aws on arm64 #32969
Conversation
|
/hold |
|
/lgtm |
|
/cc @lwan-wanglin for ARM QE peer review. can you ack this PR? Note: the cco-manual-security-token installation is failing, but it is beyond the scope of this PR. The rest looks good. |
|
/lgtm |
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, liangxia, lwan-wanglin, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aleskandro: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@aleskandro: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
#31684 introduced a logic that aims to set the compute node types in a more uniform way with cost-saving optimization as the target.
This PR injects in the newly introduced code, a default COMPUTE_NODE_TYPE for arm64 machines so that jobs configuration don't need anymore to set it (unless needed).
For the QE jobs, this also means changing from the m6g.large to the m6g.xlarge instance types for arm64 so that the testing is performed against the same amount of resources with respect to the amd64 counterpart. The PR also fixes some flakiness in cases results and issues due to the scarce resources to execute the test suites.
/cc @yunjiang29 @jiajliu