Skip to content

Conversation

@aleskandro
Copy link
Member

#31684 introduced a logic that aims to set the compute node types in a more uniform way with cost-saving optimization as the target.

This PR injects in the newly introduced code, a default COMPUTE_NODE_TYPE for arm64 machines so that jobs configuration don't need anymore to set it (unless needed).

For the QE jobs, this also means changing from the m6g.large to the m6g.xlarge instance types for arm64 so that the testing is performed against the same amount of resources with respect to the amd64 counterpart. The PR also fixes some flakiness in cases results and issues due to the scarce resources to execute the test suites.

/cc @yunjiang29 @jiajliu

@openshift-ci openshift-ci bot requested review from jiajliu and yunjiang29 October 10, 2022 05:34
@aleskandro
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@liangxia
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@aleskandro
Copy link
Member Author

/cc @lwan-wanglin

for ARM QE peer review. can you ack this PR?

Note: the cco-manual-security-token installation is failing, but it is beyond the scope of this PR. The rest looks good.

@openshift-ci openshift-ci bot requested a review from lwan-wanglin October 10, 2022 07:11
@lwan-wanglin
Copy link
Contributor

/lgtm

@aleskandro
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@vrutkovs
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, liangxia, lwan-wanglin, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9ee25a6 into openshift:master Oct 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@aleskandro: Updated the following 2 configmaps:

  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.11__arm64-nightly.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.11__arm64-nightly.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.12__arm64-nightly.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.12__arm64-nightly.yaml
Details

In response to this:

#31684 introduced a logic that aims to set the compute node types in a more uniform way with cost-saving optimization as the target.

This PR injects in the newly introduced code, a default COMPUTE_NODE_TYPE for arm64 machines so that jobs configuration don't need anymore to set it (unless needed).

For the QE jobs, this also means changing from the m6g.large to the m6g.xlarge instance types for arm64 so that the testing is performed against the same amount of resources with respect to the amd64 counterpart. The PR also fixes some flakiness in cases results and issues due to the scarce resources to execute the test suites.

/cc @yunjiang29 @jiajliu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@aleskandro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-e2e-aws-ipi-proxy-cco-manual-security-token-service-p1 4a5d9f3 link unknown /test pj-rehearse
ci/prow/pj-rehearse 4a5d9f3 link false /test pj-rehearse
ci/rehearse/openshift/cluster-capi-operator/main/e2e-aws-techpreview 4a5d9f3 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants