Skip to content

ci-operator/step-registry/ipi/install/install: Gracefully skip console.url when Console is not enabled #32262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 1 commit into from
Closed

ci-operator/step-registry/ipi/install/install: Gracefully skip console.url when Console is not enabled #32262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,33 @@ date "+%F %X" > "${SHARED_DIR}/CLUSTER_INSTALL_END_TIME"

if test "${ret}" -eq 0 ; then
touch "${SHARED_DIR}/success"
# Save console URL in `console.url` file so that ci-chat-bot could report success
echo "https://$(env KUBECONFIG=${dir}/auth/kubeconfig oc -n openshift-console get routes console -o=jsonpath='{.spec.host}')" > "${SHARED_DIR}/console.url"

CONSOLE_ENABLED=false
CLUSTER_VERSION="$(oc --kubeconfig "${dir}/auth/kubeconfig" get -o json clusterversion version)"
if [ -z "${CLUSTER_VERSION}" ]; then
echo "Unabled to retrieve ClusterVersion to check enabledCapabilities"
else
KNOWN_CAPABILITIES="$(printf '%s' "${CLUSTER_VERSION}" | jq '.status.capabilities.knownCapabilities')"
ENABLED_CAPABILITIES="$(printf '%s' "${CLUSTER_VERSION}" | jq '.status.capabilities.enabledCapabilities')"
Copy link
Member Author

@wking wking Sep 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bin/bash: line 358: jq: command not found, so we should either find an alternative approach to processing the ClusterVersion contents, find a way to install jq, or maybe process the installer output instead of trying to check in ClusterVersion...

if [ -z "${KNOWN_CAPABILITIES}" ]; then
echo "ClusterVersion does not declare knownCapabilities; assuming Console is enabled"
CONSOLE_ENABLED=true
else
CONSOLE_KNOWN="$(printf '%s' "${KNOWN_CAPABILITIES}" | jq '([.[] | . == "Console"]) | any')"
if [ true != "${CONSOLE_KNOWN}" ]; then
echo "ClusterVersion does not declare Console in knownCapabilities ({$KNOWN_CAPABILITIES}); assuming Console is enabled"
CONSOLE_ENABLED=true
elif [ null = "${ENABLED_CAPABILITIES}" ]; then
echo "ClusterVersion does not have any enabledCapabilities; Console is disabled"
else
CONSOLE_ENABLED="$(printf '%s' "${ENABLED_CAPABILITIES}" | jq '([.[] | . == "Console"]) | any')"
fi
fi
fi
if [ true = "${CONSOLE_ENABLED}" ]; then
# Save console URL in `console.url` file so that ci-chat-bot could report success
echo "https://$(oc --kubeconfig "${dir}/auth/kubeconfig" -n openshift-console get routes console -o=jsonpath='{.spec.host}')" > "${SHARED_DIR}/console.url"
fi
fi

echo "install-config.yaml"
Expand Down