-
Notifications
You must be signed in to change notification settings - Fork 2k
ci-operator/step-registry/ipi/install/install: Gracefully skip console.url when Console is not enabled #32262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
b0c4c99 to
33ca11b
Compare
…e.url when Console is not enabled Avoid noise like [1,2]: Error from server (NotFound): namespaces "openshift-console" not found when the Console cluster capability is not enabled [3]. With this commit, the output will be: Console is not a ClusterVersion enabled capability: [] [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-no-capabilities/1568745812194758656 [2]: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-no-capabilities/1568745812194758656/artifacts/e2e-aws-sdn-no-capabilities/ipi-install-install/build-log.txt [3]: openshift/console-operator#665
33ca11b to
22f5189
Compare
| echo "Unabled to retrieve ClusterVersion to check enabledCapabilities" | ||
| else | ||
| KNOWN_CAPABILITIES="$(printf '%s' "${CLUSTER_VERSION}" | jq '.status.capabilities.knownCapabilities')" | ||
| ENABLED_CAPABILITIES="$(printf '%s' "${CLUSTER_VERSION}" | jq '.status.capabilities.enabledCapabilities')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bin/bash: line 358: jq: command not found, so we should either find an alternative approach to processing the ClusterVersion contents, find a way to install jq, or maybe process the installer output instead of trying to check in ClusterVersion...
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid noise like:
when the Console cluster capability is not enabled. With this commit, the output will be: