Skip to content

ensure 'checkpolicy' is installed on GCP RHEL instances before pre-hook sshtunnel #31362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 17, 2022
Merged

ensure 'checkpolicy' is installed on GCP RHEL instances before pre-hook sshtunnel #31362

openshift-merge-robot merged 1 commit into from
Aug 17, 2022

Conversation

@jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Aug 16, 2022 •
edited
Loading

  1. update step workers-rhel-pre-hook-sshtunnel to not checking/installing checkpolicy, because of the issue on AWS RHEL instances (see here)
  2. add step workers-rhel-pre-hook-gcp for installing checkpolicy on GCP RHEL instances, as it's not installed by default
  3. update chain cucushift-installer-rehearse-gcp-ipi-disconnected-workers-rhel8-provision accordingly

@openshift-ci openshift-ci bot requested review from smg247 and yunjiang29 August 16, 2022 08:08
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Aug 16, 2022

/assign @jianlinliu @gpei @yunjiang29 please help review the minor change, thanks!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

@jianli-wei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-verification-tests-master-installer-rehearse-4.11-installer-rehearse-aws 4d06a34 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-verification-tests-master-installer-rehearse-4.10-installer-rehearse-aws 4d06a34 link unknown /test pj-rehearse
ci/prow/pj-rehearse 4d06a34 link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianlinliu
Copy link
Contributor

jianlinliu commented Aug 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5ddd36b into openshift:master Aug 17, 2022
@jianli-wei jianli-wei deleted the gcp-rhel8-checkpolicy branch August 17, 2022 09:22
@jianlinliu jianlinliu mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smg247 smg247 Awaiting requested review from smg247

@yunjiang29 yunjiang29 Awaiting requested review from yunjiang29

Assignees

@jianlinliu jianlinliu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jianli-wei @jianlinliu @openshift-merge-robot