-
Notifications
You must be signed in to change notification settings - Fork 2.1k
adding sdn workflows for aws workers-rhel8 #31307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
/retest |
|
Looks timeout again for step Try to check workflow cucushift-installer-rehearse-aws-ipi-disconnected-private-workers-rhcos-rhel8-sdn and re-trigger the test |
Sounds like there is script bug on ssh-tunnel, we are trying to fix it. |
Yes, looks like something wrong with ssh-tunnel, the job for workflow aws-ipi-disconnected-private-workers-rhcos-rhel8-sdn also hit the same issue. |
|
let us hold the testing for a while, once the issue is fixed, will notify you, after that, you can sync upstream to retest it. |
|
Thank you @jianlinliu , let me retest workflow |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about move sdn folder to aws/ipi/disconnected/private, then we can have cucushift/installer/rehearse/aws/ipi/disconnected/private/sdn/provision/cucushift-installer-rehearse-aws-ipi-disconnected-private-sdn-provision-chain.yaml, then we can reference the provision chain in the new rhel workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
Sure, I can have a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving sdn to aws/ipi/proxy/, then we will have cucushift-installer-rehearse-aws-ipi-proxy-sdn-provision-chain.yaml, based that chain, we can add rhel-workers steps to have cucushift-installer-rehearse-aws-ipi-proxy-sdn-workers-rhel8-provision-chain.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar suggestion to https://github.com/openshift/release/pull/31307/files#r954923552
|
For the downloading oc issue, I saw several recent jobs also hit such issue, sounds like test farm cluster network issues to target server: I will try to figure out some enhancement in another PR. |
|
#31256 is trying to fix oc binary downloading issue, once that PR get merge, you can sync and retest. |
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though cucushift/installer/rehearse/aws/ipi/disconnected/private/workers-rhcos-rhel8/sdn/provision/ and cucushift/installer/rehearse/aws/ipi/disconnected/private/sdn/workers-rhcos-rhel8/provision/ should have the same effect, for keeping consistent folder layout, do you mind update the layout a bit to cucushift/installer/rehearse/aws/ipi/disconnected/private/sdn/workers-rhcos-rhel8/provision/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will update it.
|
/hold |
|
/retest |
|
/retest |
|
The test for |
|
/retest |
1 similar comment
|
/retest |
|
/unhold |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianlinliu, lihongan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lihongan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@lihongan: Updated the
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.