Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Mar 1, 2019

Like f88b94e (#2910), but for the template that just came in (without using IMAGE_FORMAT) in e638cc3 (#2637).

…-40: Drop IMAGE_FORMAT

Like f88b94e (ci-operator/templates/openshift/installer: Drop
IMAGE_FORMAT, 2019-02-19, openshift#2910), but for the template that just came
in (without using IMAGE_FORMAT) in e638cc3 (BYOR 4.0: add a template
to test scaleup, 2019-01-18, openshift#2637).
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2019
@wking
Copy link
Member Author

wking commented Mar 1, 2019

CC @sdodson, @vrutkovs

@stevekuznetsov
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5af90b6 into openshift:master Mar 1, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 2 configmaps:

  • prow-job-cluster-scaleup-e2e-40 configmap in namespace ci using the following files:
    • key cluster-scaleup-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-scaleup-e2e-40.yaml
  • prow-job-cluster-scaleup-e2e-40 configmap in namespace ci-stg using the following files:
    • key cluster-scaleup-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-scaleup-e2e-40.yaml
Details

In response to this:

Like f88b94e (#2910), but for the template that just came in (without using IMAGE_FORMAT) in e638cc3 (#2637).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-image-format-again branch March 1, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants