Skip to content

BYOR 4.0: test RHEL nodes scaleup in AWS #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Jan 23, 2019
Merged

BYOR 4.0: test RHEL nodes scaleup in AWS #2637

openshift-merge-robot merged 5 commits into from
Jan 23, 2019

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jan 21, 2019

This adds a new template and job definition to test RHEL nodes scaleup in 4.0 cluster.

Vadim Rutkovsky added 5 commits January 21, 2019 11:30
BYOR 4.0: add a template to test scaleup
e638cc3 
This would setup a new AWS cluster using openshift-installer,
run test/aws/scaleup playbook from openshift-ansible and run tests.

The scaleup playbook would create additional machineset, provision it
using openshift-ansible and drain CoreOS nodes to ensure the scaled up
nodes are working correctly.
BYOR 4.0: add a presubmit job to test AWS scaleup
7237803
BYOR 4.0: update aws-4.0 profile
4dab120
Update Makefile with new changes for BYOR 4.0 scaleup
0d514b6
BYOR 4.0: scaleup tests should use ec2-user when accessing nodes
cdeea25
@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 21, 2019
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 21, 2019

/cc @sdodson

@mtnbikenc
Copy link
Member

mtnbikenc commented Jan 21, 2019

@vrutkovs Can we use the 'rehearsal' process demoed last week to test this new job?

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 21, 2019

That requires existing template - and code committed in devel-40.

It tested this manually - and the playbook starts correctly. The nodes didn't join though, might be crio issue

@vrutkovs vrutkovs mentioned this pull request Jan 22, 2019
Merged
1 task
@sdodson
Copy link
Member

sdodson commented Jan 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2019
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 22, 2019

/assign @droslean

@bbguimaraes
Copy link
Contributor

bbguimaraes commented Jan 23, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit be6b31a into openshift:master Jan 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2019

@vrutkovs: Updated the following 3 configmaps:

  • job-config configmap using the following files:
    • key openshift-openshift-ansible-devel-40-presubmits.yaml using file ci-operator/jobs/openshift/openshift-ansible/openshift-openshift-ansible-devel-40-presubmits.yaml
  • cluster-profile-aws-centos-40 configmap using the following files:
    • key vars-origin.yaml using file ``
    • key vars.yaml using file cluster/test-deploy/aws-4.0/vars.yaml
  • cluster-profile-aws-centos-40 configmap in namespace ci-stg using the following files:
    • key vars-origin.yaml using file ``
    • key vars.yaml using file cluster/test-deploy/aws-4.0/vars.yaml
Details

In response to this:

This adds a new template and job definition to test RHEL nodes scaleup in 4.0 cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-release that referenced this pull request Mar 1, 2019
@wking
ci-operator/templates/openshift/openshift-ansible/cluster-scaleup-e2e…
240fe11 
…-40: Drop IMAGE_FORMAT

Like f88b94e (ci-operator/templates/openshift/installer: Drop
IMAGE_FORMAT, 2019-02-19, openshift#2910), but for the template that just came
in (without using IMAGE_FORMAT) in e638cc3 (BYOR 4.0: add a template
to test scaleup, 2019-01-18, openshift#2637).
@wking wking mentioned this pull request Mar 1, 2019
Merged
@vrutkovs vrutkovs deleted the byor-40-scaleup branch January 27, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@sdodson sdodson

@droslean droslean

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vrutkovs @mtnbikenc @sdodson @bbguimaraes @openshift-ci-robot @droslean @openshift-merge-robot