Skip to content

Conversation

@hardys
Copy link
Contributor

@hardys hardys commented Jun 15, 2022

This is missing the QE approvers so adding here to align with the
other related metal-platform repos

This is missing the QE approvers so adding here to align with the
other related metal-platform repos
@hardys
Copy link
Contributor Author

hardys commented Jun 15, 2022

/cc @elfosardo @lshilin-r

This was noticed on openshift/image-customization-controller#43

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@elfosardo
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@hardys: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit bbd5949 into openshift:master Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@hardys: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-openshift-image-customization-controller-_pluginconfig.yaml using file core-services/prow/02_config/openshift/image-customization-controller/_pluginconfig.yaml
Details

In response to this:

This is missing the QE approvers so adding here to align with the
other related metal-platform repos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants