Bug 2061977: Restart ironic-agent.service when it fails #43

bfournie · 2022-03-08T20:54:27Z

Signed-off-by: Zhou Hao [email protected]
(cherry picked from commit 6a48405)

Signed-off-by: Zhou Hao <[email protected]> (cherry picked from commit 6a48405)

openshift-ci · 2022-03-08T20:54:33Z

@bfournie: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-08T20:55:14Z

@bfournie: This pull request references Bugzilla bug 2061977, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtantsur · 2022-03-10T11:49:18Z

/lgtm
/retest

openshift-bot · 2022-03-11T01:00:28Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-11T01:00:33Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bfournie · 2022-03-11T13:29:26Z

/retest

openshift-bot · 2022-03-12T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-12T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-13T01:00:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-13T01:00:18Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-14T01:00:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-14T01:00:22Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-15T01:00:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-15T01:00:27Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bfournie · 2022-03-15T21:50:18Z

/retest

openshift-ci · 2022-03-16T00:43:00Z

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-03-16T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-16T01:01:17Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-17T01:00:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-17T01:00:27Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-18T01:01:10Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-18T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-11T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-06-12T01:01:23Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-06-12T01:01:56Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bfournie · 2022-06-12T15:44:27Z

/hold
The parent PR that this was backported from did not solve the problem and another fix was needed, see #51. Marking this as /hold, the additional fix will need to be incorporated here if it fixes the problem.
/cc @elfosardo

elfosardo · 2022-06-13T15:00:41Z

/unhold
/bugzilla refresh
it's still worth merging this before backporting #51

openshift-ci · 2022-06-13T15:00:45Z

@elfosardo: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-06-14T01:01:28Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-06-14T01:01:59Z

@openshift-bot: This pull request references Bugzilla bug 2061977, which is invalid:

expected dependent Bugzilla bug 2060968 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elfosardo · 2022-06-14T07:00:53Z

/bugzilla refresh

openshift-ci · 2022-06-14T07:01:02Z

@elfosardo: This pull request references Bugzilla bug 2061977, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.z) matches configured target release for branch (4.10.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2060968 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2060968 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtantsur · 2022-06-15T07:23:22Z

/approve
/label backport-risk-assessed

hardys · 2022-06-15T09:35:31Z

/approve

openshift-ci · 2022-06-15T09:35:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, dtantsur, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lshilin-r · 2022-06-15T15:00:39Z

/label cherry-pick-approved

openshift-ci · 2022-06-15T15:00:48Z

@lshilin-r: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-patch-managers]

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2022-06-15T15:44:17Z

Seems we're missing the necessary prow config for this repo so I'll add the label until we fix that

openshift-ci · 2022-06-15T16:19:10Z

@bfournie: All pull requests linked via external trackers have merged:

openshift/image-customization-controller#43

Bugzilla bug 2061977 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Restart ironic-agent.service when it fails

e730a83

Signed-off-by: Zhou Hao <[email protected]> (cherry picked from commit 6a48405)

bfournie changed the title ~~Restart ironic-agent.service when it fails~~ Bug 2061977: Restart ironic-agent.service when it fails Mar 8, 2022

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 8, 2022

openshift-ci bot requested review from hardys and honza March 8, 2022 20:56

openshift-ci bot assigned dtantsur Mar 10, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022

openshift-ci bot requested a review from elfosardo June 12, 2022 15:44

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2022

elfosardo mentioned this pull request Jun 13, 2022

[release-4.10] Restart ironic-agent.service when it fails #52

Closed

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2022

elfosardo mentioned this pull request Jun 13, 2022

Bug 2060968: Add delay between ironic-agent restart, but restart forever #51

Merged

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 14, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 15, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022

hardys added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 15, 2022

hardys mentioned this pull request Jun 15, 2022

Add missing icc repo cherry-pick approvers openshift/release#29518

Merged

openshift-ci bot merged commit ccd7046 into openshift:release-4.10 Jun 15, 2022

openshift-ci bot mentioned this pull request Jun 22, 2022

Bug 2061977: Add delay between ironic-agent restart, but restart forever #54

Merged

Bug 2061977: Restart ironic-agent.service when it fails #43

Bug 2061977: Restart ironic-agent.service when it fails #43

Uh oh!

Conversation

bfournie commented Mar 8, 2022

Uh oh!

openshift-ci bot commented Mar 8, 2022

Uh oh!

openshift-ci bot commented Mar 8, 2022

Uh oh!

dtantsur commented Mar 10, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-ci bot commented Mar 11, 2022

Uh oh!

bfournie commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 12, 2022

Uh oh!

openshift-ci bot commented Mar 12, 2022

Uh oh!

openshift-bot commented Mar 13, 2022

Uh oh!

openshift-ci bot commented Mar 13, 2022

Uh oh!

openshift-bot commented Mar 14, 2022

Uh oh!

openshift-ci bot commented Mar 14, 2022

Uh oh!

openshift-bot commented Mar 15, 2022

Uh oh!

openshift-ci bot commented Mar 15, 2022

Uh oh!

bfournie commented Mar 15, 2022

Uh oh!

openshift-ci bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 16, 2022

Uh oh!

openshift-ci bot commented Mar 16, 2022

Uh oh!

openshift-bot commented Mar 17, 2022

Uh oh!

openshift-ci bot commented Mar 17, 2022

Uh oh!

openshift-bot commented Mar 18, 2022

Uh oh!

openshift-ci bot commented Mar 18, 2022

Uh oh!

openshift-ci bot commented Jun 11, 2022

Uh oh!

openshift-bot commented Jun 12, 2022

Uh oh!

openshift-ci bot commented Jun 12, 2022

Uh oh!

bfournie commented Jun 12, 2022

Uh oh!

elfosardo commented Jun 13, 2022

Uh oh!

openshift-ci bot commented Jun 13, 2022

Uh oh!

openshift-bot commented Jun 14, 2022

Uh oh!

openshift-ci bot commented Jun 14, 2022

Uh oh!

elfosardo commented Jun 14, 2022

Uh oh!

openshift-ci bot commented Jun 14, 2022

Uh oh!

dtantsur commented Jun 15, 2022

Uh oh!

hardys commented Jun 15, 2022

Uh oh!

openshift-ci bot commented Jun 15, 2022

Uh oh!

lshilin-r commented Jun 15, 2022

Uh oh!

openshift-ci bot commented Jun 15, 2022

Uh oh!